Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 329025: Rebaseline tests that changed upstream: (Closed)

Created:
11 years, 1 month ago by tony
Modified:
9 years, 7 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : passing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -214 lines) Patch
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/4641880-2-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/4916541-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/5138441-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/5481523-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/indent-selection-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/pasteboard/select-element-1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/4641880-2-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/4916541-expected.txt View 1 chunk +9 lines, -7 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/5138441-expected.txt View 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/5481523-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/execCommand/indent-selection-expected.txt View 3 chunks +10 lines, -8 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/4641880-2-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/4916541-expected.txt View 1 chunk +9 lines, -7 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/5138441-expected.txt View 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/5481523-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/indent-selection-expected.txt View 3 chunks +10 lines, -8 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/5994480-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/select-element-1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
11 years, 1 month ago (2009-10-26 22:21:49 UTC) #1
ojan
http://codereview.chromium.org/329025/diff/1/13 File webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/inserting/5994480-2-expected.txt (right): http://codereview.chromium.org/329025/diff/1/13#newcode1 Line 1: <font class="Apple-style-span" face="'Lucida Grande'" size="3"><span class="Apple-style-span" style="background-color: rgb(255, ...
11 years, 1 month ago (2009-10-26 22:36:04 UTC) #2
tony
You're right. This test is actually passing on the bots. I've removed the result. On ...
11 years, 1 month ago (2009-10-26 22:42:25 UTC) #3
ojan
11 years, 1 month ago (2009-10-26 22:53:02 UTC) #4
lgtm

On Mon, Oct 26, 2009 at 3:42 PM, <tony@chromium.org> wrote:

> You're right.  This test is actually passing on the bots.  I've removed the
> result.
>
>
> On 2009/10/26 22:36:04, ojan wrote:
>
>> http://codereview.chromium.org/329025/diff/1/13
>> File
>>
>
>
>
webkit/data/layout_tests/platform/chromium-mac/LayoutTests/editing/inserting/5994480-2-expected.txt
>
>> (right):
>>
>
>  http://codereview.chromium.org/329025/diff/1/13#newcode1
>> Line 1: <font class="Apple-style-span" face="'Lucida Grande'"
>> size="3"><span
>> class="Apple-style-span" style="background-color: rgb(255, 255, 255);
>>
> font-size:
>
>> 11px; -webkit-border-vertical-spacing: 0px;"><br></span></font>
>> Why don't we match upstream here? Seems like we used to.
>>
>
>
>
> http://codereview.chromium.org/329025
>

Powered by Google App Engine
This is Rietveld 408576698