Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 329009: CompactNavigationBar for toolkit views build, with some design change per Cole's request. (Closed)

Created:
11 years, 2 months ago by oshima
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

CompactNavigationBar for toolkit views build, with some design change per Cole's request. * Swapped the positions of entry field and navigation buttons. * Hide navigation buttions when the entry field gains focus. - To implement this, I added OnKillFocus in AutocompleteEditController, and updated corresponding files. * Added accelerator (shift-ctrl-0) to toggle compact navigation bar Changes to BrowserExtender * Made all virtual methods in BrowserExtender pure virtual. * Added HideToolbar method to control visibility of toolbar from Extender. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30082

Patch Set 1 #

Patch Set 2 : style fix #

Patch Set 3 : style fix #

Total comments: 8

Patch Set 4 : updates per review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -48 lines) Patch
M chrome/app/chrome_dll_resource.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/browser.cc View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/browser_window.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chromeos_browser_extenders.cc View 1 2 3 6 chunks +61 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/compact_navigation_bar.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/compact_navigation_bar.cc View 1 2 3 chunks +45 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/status_area_view.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/cocoa/location_bar_view_mac.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/location_bar_view_mac.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/accelerator_table_gtk.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_extender.h View 1 2 3 3 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/views/frame/standard_extender.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/location_bar_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/location_bar_view.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/test_browser_window.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
11 years, 2 months ago (2009-10-23 18:57:15 UTC) #1
brettw
http://codereview.chromium.org/329009/diff/7004/7012 File chrome/browser/chromeos/chromeos_browser_extenders.cc (right): http://codereview.chromium.org/329009/diff/7004/7012#newcode109 Line 109: width = std::max(0, width); // in case there ...
11 years, 2 months ago (2009-10-23 22:21:50 UTC) #2
oshima
http://codereview.chromium.org/329009/diff/7004/7012 File chrome/browser/chromeos/chromeos_browser_extenders.cc (right): http://codereview.chromium.org/329009/diff/7004/7012#newcode109 Line 109: width = std::max(0, width); // in case there ...
11 years, 2 months ago (2009-10-23 22:49:00 UTC) #3
brettw
11 years, 2 months ago (2009-10-23 22:50:05 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698