Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2332)

Unified Diff: chrome/browser/views/frame/browser_extender.h

Issue 329009: CompactNavigationBar for toolkit views build, with some design change per Cole's request. (Closed)
Patch Set: updates per review Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/accelerator_table_gtk.cc ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/frame/browser_extender.h
diff --git a/chrome/browser/views/frame/browser_extender.h b/chrome/browser/views/frame/browser_extender.h
index 6481d117e93d3e20efee29b65e7de6847ed8bdc4..094bd2d14ab48e51bd2176b86b951db30f423c61 100644
--- a/chrome/browser/views/frame/browser_extender.h
+++ b/chrome/browser/views/frame/browser_extender.h
@@ -18,7 +18,7 @@ class Window;
// BrowserExtender adds chromeos specific features to BrowserView.
// The factory method |Create(BrowserView*)| creates different types
// of extender depending on the type of BrowserView and target platform.
-// Please see chromeos_browser_extender.cc for ChromeOS extenders, and
+// Please see chromeos_browser_extenders.cc for ChromeOS extenders, and
// standard_extender.cc for Chrome browser.
class BrowserExtender {
public:
@@ -33,23 +33,30 @@ class BrowserExtender {
// Layouts controls within the given bounds and returns the remaining
// bounds for tabstip to be layed out.
- virtual gfx::Rect Layout(const gfx::Rect& bounds) { return bounds; }
+ virtual gfx::Rect Layout(const gfx::Rect& bounds) = 0;
// Tests if the given |point|, which is given in BrowserView coordinates,
// hits any of controls.
virtual bool NonClientHitTest(const gfx::Point& browser_view_point) = 0;
// Updates the title bar (if any).
- virtual void UpdateTitleBar() {}
+ virtual void UpdateTitleBar() = 0;
// Called when the BrowserView is shown.
virtual void Show() = 0;
// Called when the BrowserView is closed.
- virtual void Close() {}
+ virtual void Close() = 0;
// Called when the browser window is either activated or deactivated.
- virtual void ActivationChanged() {}
+ virtual void ActivationChanged() = 0;
+
+ // Returns true to hide the toolbar for the window, or false
+ // to use the regular logic to decide.
+ virtual bool ShouldForceHideToolbar() = 0;
+
+ // Toggles the visibility of CompactNavigationBar.
+ virtual void ToggleCompactNavigationBar() = 0;
// Tells if the browser can be closed.
bool can_close() const {
@@ -83,4 +90,3 @@ class BrowserExtender {
};
#endif // CHROME_BROWSER_CHROMEOS_BROWSER_EXTENDER_H_
-
« no previous file with comments | « chrome/browser/views/accelerator_table_gtk.cc ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698