Mac: enable History, Downloads, and Open Location... with no windows open.

Mac: enable History, Downloads, and Open Location... with no windows open.

BUG=25620
TEST=Close all windows, try History->History (Cmd-Y); close window, try Window->Downloads (Shift-Cmd-J); close window, try Open Location... (Cmd-L).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30615

[pink (ping after 24hrs), 2009-10-23 13:49:32]

There are other places as well (such as opening the themes page and license
page) that use OpenURL after manually creating a new browser window. 

What do we want to do with those? cc'ing ben for a decision.

We'll probably have more of these in the future. Do we want the caller to be
responsible for creating the Browser and calling the right method, or have a
static method for all of them?

[viettrungluu, 2009-10-23 14:56:30]

On 2009/10/23 13:49:32, pink wrote:
> There are other places as well (such as opening the themes page and license
> page) that use OpenURL after manually creating a new browser window. 
> 
> What do we want to do with those? cc'ing ben for a decision.
> 
> We'll probably have more of these in the future. Do we want the caller to be
> responsible for creating the Browser and calling the right method, or have a
> static method for all of them?

As I said (and will repeat for the benefit of Ben), my feeling is that
Open/ShowXYZTab() methods should have corresponding static OpenXYZWindow()
methods. Possibly, we should have a static OpenURLInNewWindow() (or something
like that) method.

[viettrungluu, 2009-10-26 19:10:55]

ben: ping

[Ben Goodger (Google), 2009-10-26 21:29:55]

I don't know that creating a new window is always the right thing to do?
What if there's an existing window?

Ideally we'd have one OpenURLFromUI function on the Browser. It'd be smart
for chrome:// URLs and recycle existing instances (focus an existing tab),
reuse the last active window, etc.

-Ben

On Mon, Oct 26, 2009 at 12:10 PM, <viettrungluu@chromium.org> wrote:

> ben: ping
>
>
> http://codereview.chromium.org/329004
>

[Ben Goodger (Google), 2009-10-26 22:56:02]

I am OK with your approach in the short term, I would still fancy a magic
method at some point.

-Ben

On Mon, Oct 26, 2009 at 3:52 PM, <viettrungluu@chromium.org> wrote:

> For the usage in this CL, the static OpenXYZWindow() methods are only
> called
> when there's no active browser window available; "active" means not
> minimized
> and not running a window modal dialog. The app controller doesn't have to
> decide
> whether to open a window or a tab since it only gets the command if there's
> no
> active browser window.
>
> The use of OpenURL() in the prefs dialog for the themes page is different,
> since
> it's coming from a non-modal dialog: it has to look for a browser window,
> and it
> creates one only if necessary. There should be a common way to do this to
> avoid
> code duplication (the check is also trickier than it seems; the current
> implementation breaks if a window modal dialog is up).
>
> Whether a smart OpenURLFromUI() should replace explicit Open/ShowXYZTab()
> and
> OpenXYZWindow() methods is a separate issue. It seems a bit silly to use a
> super-general method in situations where we already know what we want to do
> (open/show a tab in an existing window or create a new window).
>
> - Trung
>
>
> On 2009/10/26 21:29:55, Ben Goodger wrote:
>
>> I don't know that creating a new window is always the right thing to do?
>> What if there's an existing window?
>>
>
>  Ideally we'd have one OpenURLFromUI function on the Browser. It'd be smart
>> for chrome:// URLs and recycle existing instances (focus an existing tab),
>> reuse the last active window, etc.
>>
>
>  -Ben
>>
>
>  On Mon, Oct 26, 2009 at 12:10 PM, <mailto:viettrungluu@chromium.org>
>> wrote:
>>
>
>  > ben: ping
>> >
>> >
>> > http://codereview.chromium.org/329004
>> >
>>
>
>
>
>
> http://codereview.chromium.org/329004
>

[pink (ping after 24hrs), 2009-10-30 17:42:50]

LGTM then