Issue 328026: Fix regression where popups and app frames lost their titlebars....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328026: Fix regression where popups and app frames lost their titlebars.... (Closed)

Created:
11 years, 1 month ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix regression where popups and app frames lost their titlebars. TBR=pkasting http://crbug.com/25784 TEST=open any popup window or app frame, should have title bar to drag window. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30029

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/views/frame/browser_frame_win.cc	View		1 chunk	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

11 years, 1 month ago (2009-10-26 07:41:23 UTC) #2

LGTM.

http://codereview.chromium.org/328026/diff/1/2
File chrome/browser/views/frame/browser_frame_win.cc (right):

http://codereview.chromium.org/328026/diff/1/2#newcode128
Line 128: !browser_view_->IsBrowserTypeNormal()) {
Nit: No need for {}.

Expand Messages | Collapse Messages