Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 328026: Fix regression where popups and app frames lost their titlebars.... (Closed)

Created:
11 years, 1 month ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Fix regression where popups and app frames lost their titlebars. TBR=pkasting http://crbug.com/25784 TEST=open any popup window or app frame, should have title bar to drag window. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30029

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/views/frame/browser_frame_win.cc View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
11 years, 1 month ago (2009-10-26 02:40:47 UTC) #1
Peter Kasting
11 years, 1 month ago (2009-10-26 07:41:23 UTC) #2
LGTM.

http://codereview.chromium.org/328026/diff/1/2
File chrome/browser/views/frame/browser_frame_win.cc (right):

http://codereview.chromium.org/328026/diff/1/2#newcode128
Line 128: !browser_view_->IsBrowserTypeNormal()) {
Nit: No need for {}.

Powered by Google App Engine
This is Rietveld 408576698