Fix regression where popups and app frames lost their titlebars....

chrome/browser/views/frame/browser_frame_win.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/frame/browser_frame_win.h"
 
 #include <dwmapi.h>
 #include <shellapi.h>
 
 #include <set>
@@ skipping 104 matching lines @@
   // for popups/apps.
   return GetThemeProvider()->ShouldUseNativeFrame() ||
       (!browser_view_->IsBrowserTypeNormal() &&
       win_util::ShouldUseVistaFrame());
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserFrame, views::WindowWin overrides:
 
 gfx::Insets BrowserFrameWin::GetClientAreaInsets() const {
-  if (!GetNonClientView()->UseNativeFrame())
+  // Use the default client insets for an opaque frame or a glass popup/app
+  // frame.
+  if (!GetNonClientView()->UseNativeFrame() ||
+      !browser_view_->IsBrowserTypeNormal()) {

[Peter Kasting, 2009/10/26 07:41:24]

Nit: No need for {}.

     return WindowWin::GetClientAreaInsets();
+  }
 
   int border_thickness = GetSystemMetrics(SM_CXSIZEFRAME);
   // We draw our own client edge over part of the default frame.
   if (!IsMaximized())
     border_thickness -= kClientEdgeThickness;
   return gfx::Insets(0, border_thickness, border_thickness, border_thickness);
 }
 
 bool BrowserFrameWin::GetAccelerator(int cmd_id,
                                      views::Accelerator* accelerator) {
@@ skipping 191 matching lines @@
     // more "transparent" look.
     ::SetWindowLong(frame_hwnd, GWL_STYLE,
                     saved_window_style_ & ~WS_CAPTION);
     SetLayeredWindowAttributes(frame_hwnd, RGB(0xFF, 0xFF, 0xFF),
                                kTabDragWindowAlpha, LWA_ALPHA);
   } else {
     ::SetWindowLong(frame_hwnd, GWL_STYLE, saved_window_style_);
     ::SetWindowLong(frame_hwnd, GWL_EXSTYLE, saved_window_ex_style_);
   }
 }