Makes it so that when a folder is open on the bookmark bar and the...

Makes it so that when a folder is open on the bookmark bar and the
mouse moves over another folder, the menu for that folder is shown.

BUG=355
TEST=thorougly test all possible permutations of bookmark menus you
     can think of, including drag and drop to the menus.

[jcampan, 2009-10-23 22:27:24]

Is that the right bug number?

Jay

On Fri, Oct 23, 2009 at 2:46 PM,  <sky@chromium.org> wrote:
> Reviewers: jcampan,
>
> Description:
> Makes it so that when a folder is open on the bookmark bar and the
> mouse moves over another folder, the menu for that folder is shown.
>
> BUG=3D255
> TEST=3Dthorougly test all possible permutations of bookmark menus you
> =A0 =A0 can think of, including drag and drop to the menus.
>
>
> Please review this at http://codereview.chromium.org/328012
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/views/bookmark_bar_view.h
> =A0M =A0 =A0 chrome/browser/views/bookmark_bar_view.cc
> =A0M =A0 =A0 chrome/browser/views/bookmark_bar_view_test.cc
> =A0M =A0 =A0 chrome/browser/views/bookmark_context_menu.cc
> =A0M =A0 =A0 chrome/browser/views/bookmark_manager_view.cc
> =A0M =A0 =A0 chrome/browser/views/bookmark_menu_button.cc
> =A0M =A0 =A0 chrome/browser/views/bookmark_menu_controller_views.h
> =A0M =A0 =A0 chrome/browser/views/bookmark_menu_controller_views.cc
> =A0M =A0 =A0 views/controls/button/menu_button.cc
> =A0M =A0 =A0 views/controls/menu/menu_controller.h
> =A0M =A0 =A0 views/controls/menu/menu_controller.cc
> =A0M =A0 =A0 views/controls/menu/menu_delegate.h
> =A0M =A0 =A0 views/controls/menu/menu_host_gtk.h
> =A0M =A0 =A0 views/controls/menu/menu_host_gtk.cc
> =A0M =A0 =A0 views/controls/menu/menu_host_win.h
> =A0M =A0 =A0 views/controls/menu/menu_host_win.cc
> =A0M =A0 =A0 views/controls/menu/menu_item_view.h
> =A0M =A0 =A0 views/controls/menu/menu_item_view.cc
> =A0M =A0 =A0 views/controls/menu/submenu_view.cc
> =A0M =A0 =A0 views/screen.h
> =A0M =A0 =A0 views/screen_gtk.cc
> =A0M =A0 =A0 views/screen_win.cc
>
>
>

[sky, 2009-10-23 22:30:56]

D'OH! That should be 355. I've updated the description.

  -Scott

On 2009/10/23 22:27:24, jcampan wrote:
> Is that the right bug number?
> 
> Jay
> 
> On Fri, Oct 23, 2009 at 2:46 PM,  <mailto:sky@chromium.org> wrote:
> > Reviewers: jcampan,
> >
> > Description:
> > Makes it so that when a folder is open on the bookmark bar and the
> > mouse moves over another folder, the menu for that folder is shown.
> >
> > BUG=3D255
> > TEST=3Dthorougly test all possible permutations of bookmark menus you
> > =A0 =A0 can think of, including drag and drop to the menus.
> >
> >
> > Please review this at http://codereview.chromium.org/328012
> >
> > SVN Base: svn://chrome-svn/chrome/trunk/src/
> >
> > Affected files:
> > =A0M =A0 =A0 chrome/browser/views/bookmark_bar_view.h
> > =A0M =A0 =A0 chrome/browser/views/bookmark_bar_view.cc
> > =A0M =A0 =A0 chrome/browser/views/bookmark_bar_view_test.cc
> > =A0M =A0 =A0 chrome/browser/views/bookmark_context_menu.cc
> > =A0M =A0 =A0 chrome/browser/views/bookmark_manager_view.cc
> > =A0M =A0 =A0 chrome/browser/views/bookmark_menu_button.cc
> > =A0M =A0 =A0 chrome/browser/views/bookmark_menu_controller_views.h
> > =A0M =A0 =A0 chrome/browser/views/bookmark_menu_controller_views.cc
> > =A0M =A0 =A0 views/controls/button/menu_button.cc
> > =A0M =A0 =A0 views/controls/menu/menu_controller.h
> > =A0M =A0 =A0 views/controls/menu/menu_controller.cc
> > =A0M =A0 =A0 views/controls/menu/menu_delegate.h
> > =A0M =A0 =A0 views/controls/menu/menu_host_gtk.h
> > =A0M =A0 =A0 views/controls/menu/menu_host_gtk.cc
> > =A0M =A0 =A0 views/controls/menu/menu_host_win.h
> > =A0M =A0 =A0 views/controls/menu/menu_host_win.cc
> > =A0M =A0 =A0 views/controls/menu/menu_item_view.h
> > =A0M =A0 =A0 views/controls/menu/menu_item_view.cc
> > =A0M =A0 =A0 views/controls/menu/submenu_view.cc
> > =A0M =A0 =A0 views/screen.h
> > =A0M =A0 =A0 views/screen_gtk.cc
> > =A0M =A0 =A0 views/screen_win.cc
> >
> >
> >

[jcampan, 2009-10-23 22:58:08]

http://codereview.chromium.org/328012/diff/1/16
File chrome/browser/views/bookmark_menu_controller_views.cc (right):

http://codereview.chromium.org/328012/diff/1/16#newcode66
Line 66: button->height() - 1);
Why the -1?

http://codereview.chromium.org/328012/diff/1/19
File chrome/browser/views/bookmark_menu_controller_views.h (right):

http://codereview.chromium.org/328012/diff/1/19#newcode120
Line 120: // BuildMenu to recrusively populate the menu.
Typo: recursively

http://codereview.chromium.org/328012/diff/1/8
File views/controls/menu/menu_controller.cc (right):

http://codereview.chromium.org/328012/diff/1/8#newcode883
Line 883: 
Remove empty line.

[sky, 2009-10-23 23:42:08]

The -1 matches what the old code in BookmarkBarView was doing. I've added a
comment to that effect and uploaded a new patch, along with fixing the other
changes.

  -Scott

[jcampan, 2009-10-23 23:44:08]

LGTM