Issue 3274008: Get gcc to check that we don't ignore return values of functions that can...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3274008: Get gcc to check that we don't ignore return values of functions that can... (Closed)

Created:
10 years, 3 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Get gcc to check that we don't ignore return values of functions that can fail to allocate because we need a GC. Committed: http://code.google.com/p/v8/source/detail?r=5379

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+334 lines, -284 lines)			Patch
M	src/accessors.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/builtins.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/debug.cc	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/heap.h	View	18 chunks	+106 lines, -99 lines	0 comments	Download
M	src/liveedit.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/objects.h	View	29 chunks	+62 lines, -57 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/parser.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	src/stub-cache.h	View	1 chunk	+107 lines, -101 lines	0 comments	Download
M	src/utils.h	View	1 chunk	+7 lines, -0 lines	1 comment	Download
M	test/cctest/test-heap.cc	View	4 chunks	+20 lines, -9 lines	0 comments	Download
M	test/mjsunit/const-eval-init.js	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

10 years, 3 months ago (2010-08-30 16:31:25 UTC) #2

LGTM if it compiles at least on GCC 4.3 and GCC 4.4

http://codereview.chromium.org/3274008/diff/1/12
File src/utils.h (right):

http://codereview.chromium.org/3274008/diff/1/12#newcode955
src/utils.h:955: #ifdef __GNUC__
1) GCC reference manual mentions this attribute starting from 3.4 so v8 will
fail to compile by previous versions of GCC.
2) there are some differences in __attribute__ syntax [position of __attribute__
modifier for GCC <4 and GCC >=4]. See INLINE macro.
3) Can we come up with more informative name? NOIGNORE is difficult to
understand. NOIGNORE what? 
4) Maybe move this definitions to globals.h alongside with INLINE macroses?

Expand Messages | Collapse Messages