Issue 326012: Check word lengths before adding to dictionary and spellchecking....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 326012: Check word lengths before adding to dictionary and spellchecking.... (Closed)

Created:
11 years, 2 months ago by jschuh

Modified:
9 years, 6 months ago

Reviewers:
brettw, Chris Evans

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Check word lengths before adding to dictionary and spellchecking. BUG=20469 TEST=None

Patch Set 2 : Audited the code more and determined that a more conservative maximum is need... #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/spellchecker.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jschuh

I added a quick length check on the words entering hunspell via spellcheck or adding ...

11 years, 2 months ago (2009-10-23 15:59:49 UTC) #1

cevans

I landed this for Justin http://src.chromium.org/viewvc/chrome?view=rev&revision=29929 <http://src.chromium.org/viewvc/chrome?view=rev&revision=29929>Justin, you can log in to codereview.chromium.org and close ...

11 years, 2 months ago (2009-10-23 19:45:37 UTC) #3

jschuh

I dug deeper into the suggest code and noticed that Hunspell alternates between between maximum ...

11 years, 1 month ago (2009-10-30 15:28:54 UTC) #4

Chris Evans

LGTM On 2009/10/30 15:28:54, jschuh wrote: > I dug deeper into the suggest code and ...

11 years, 1 month ago (2009-10-31 02:30:10 UTC) #5

LGTM

Expand Messages | Collapse Messages

Issue 326012: Check word lengths before adding to dictionary and spellchecking.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : Audited the code more and determined that a more conservative maximum is need... #

Messages