Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 326008: Clarified the manifest example code. Added "version" description.... (Closed)

Created:
11 years, 2 months ago by Kathy Walrath
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Clarified the manifest example code. Added "version" description. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29905

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -61 lines) Patch
M chrome/common/extensions/docs/manifest.html View 1 5 chunks +79 lines, -32 lines 0 comments Download
M chrome/common/extensions/docs/static/manifest.html View 1 4 chunks +75 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kathy Walrath
Please pay special attention to the new version section (bottom of the page).
11 years, 2 months ago (2009-10-23 06:02:13 UTC) #1
Aaron Boodman
* You can get rid of the "icon" section. That is deprecated. * The description ...
11 years, 2 months ago (2009-10-23 06:13:41 UTC) #2
Kathy Walrath
11 years, 2 months ago (2009-10-23 07:00:42 UTC) #3
On 2009/10/23 06:13:41, Aaron Boodman wrote:
> * You can get rid of the "icon" section. That is deprecated.

Cool. Done.

> * The description of the permissions field reads awkwardly to me. 

I've rewritten it a bit. I tried to make it a little future proof (removing the
"currently", e.g.) and added some (hopefully reassuring) text about where they
(the developer, that is) would learn about permissions.

Powered by Google App Engine
This is Rietveld 408576698