Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 3256001: Revert 57635: Implement about:labs (Closed)

Created:
10 years, 4 months ago by Dmitry Polukhin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, brettw-cc_chromium.org, pam+watch_chromium.org, arv (Not doing code reviews), ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Revert 57635: Implement about:labs Original CL: http://codereview.chromium.org/3152055 Implement about:labs Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet. BUG=53399 TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation) TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -915 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 5 chunks +4 lines, -20 lines 0 comments Download
M chrome/browser/browser_main.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 4 chunks +0 lines, -7 lines 0 comments Download
D chrome/browser/dom_ui/labs_ui.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/dom_ui/labs_ui.cc View 1 chunk +0 lines, -196 lines 0 comments Download
M chrome/browser/dom_ui/plugins_ui.cc View 3 chunks +19 lines, -3 lines 0 comments Download
D chrome/browser/labs.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/labs.cc View 1 chunk +0 lines, -231 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 3 chunks +1 line, -5 lines 0 comments Download
D chrome/browser/resources/labs.html View 1 chunk +0 lines, -311 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/url_constants.h View 4 chunks +8 lines, -12 lines 0 comments Download
M chrome/common/url_constants.cc View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dmitry Polukhin
10 years, 4 months ago (2010-08-27 11:45:33 UTC) #1
Nico
10 years, 3 months ago (2010-08-27 13:18:42 UTC) #2
LG

The reason for the breakage is that I "protected"
`PluginsUI::RegisterUserPrefs(user_prefs);` with `if
(about_labs::IsEnabled())` instead of
`LabsUI::RegisterUserPrefs(user_prefs);` as I intended. Fixed &
relanded.

On Fri, Aug 27, 2010 at 4:45 AM,  <dpolukhin@chromium.org> wrote:
> Reviewers: viettrungluu, arv, Nico,
>
> Description:
> Revert 57635: Implement about:labs
>
> Original CL: http://codereview.chromium.org/3152055
>
> Implement about:labs
>
> Tabpose is currently the only lab on mac, tabs-on-left the only lab on
> windows.
> Nothing for linux yet.
>
> BUG=53399
> TEST=Go to about:labs. Should have one feature on windows and osx each, none
> on
> linux yet. about:labs should not be visible on the stable channel. Labs that
> were enabled on the dev channel should not be enabled on the stable channel.
> about:labs in chromeos should still work (they use a different
> implementation)
> TBR=thakis@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57664
>
> Please review this at http://codereview.chromium.org/3256001/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M chrome/app/generated_resources.grd
>  M chrome/app/theme/theme_resources.grd
>  M chrome/browser/app_controller_mac.mm
>  M chrome/browser/browser_about_handler.cc
>  M chrome/browser/browser_main.cc
>  M chrome/browser/browser_resources.grd
>  M chrome/browser/dom_ui/dom_ui_factory.cc
>  D chrome/browser/dom_ui/labs_ui.h
>  D chrome/browser/dom_ui/labs_ui.cc
>  M chrome/browser/dom_ui/plugins_ui.cc
>  D chrome/browser/labs.h
>  D chrome/browser/labs.cc
>  M chrome/browser/prefs/browser_prefs.cc
>  D chrome/browser/resources/labs.html
>  M chrome/chrome_browser.gypi
>  M chrome/common/pref_names.h
>  M chrome/common/pref_names.cc
>  M chrome/common/url_constants.h
>  M chrome/common/url_constants.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698