Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 3152055: Implement about:labs (Closed)

Created:
10 years, 4 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr., John Grabowski, pam+watch_chromium.org
Visibility:
Public.

Description

Implement about:labs Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet. BUG=53399 TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57635 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57670

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : html file close #

Patch Set 6 : '' #

Patch Set 7 : second 90% #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : rebase #

Total comments: 12

Patch Set 11 : comments #

Patch Set 12 : '' #

Total comments: 3

Patch Set 13 : '' #

Patch Set 14 : rebase #

Total comments: 7

Patch Set 15 : '' #

Patch Set 16 : chromeos fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+914 lines, -39 lines) Patch
M chrome/app/generated_resources.grd View 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 7 8 9 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 5 chunks +20 lines, -4 lines 0 comments Download
M chrome/browser/browser_main.cc View 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +7 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/labs_ui.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/labs_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +196 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/plugins_ui.cc View 3 4 5 6 7 8 9 3 chunks +3 lines, -19 lines 0 comments Download
A chrome/browser/labs.h View 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/labs.cc View 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +231 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 10 11 12 13 14 15 3 chunks +4 lines, -0 lines 0 comments Download
A chrome/browser/resources/labs.html View 1 2 3 4 5 1 chunk +311 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 3 4 5 6 7 8 9 14 15 1 chunk +1 line, -0 lines 0 comments Download
chrome/common/pref_names.cc View 3 4 5 6 7 8 9 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +12 lines, -8 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 4 5 6 7 8 9 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
10 years, 3 months ago (2010-08-26 23:21:21 UTC) #1
viettrungluu
Haven't looked at it all yet. Could I get a screenshot? http://codereview.chromium.org/3152055/diff/25002/27005 File chrome/browser/browser_about_handler.cc (right): ...
10 years, 3 months ago (2010-08-26 23:48:35 UTC) #2
Nico
thanks, sent you screenshots via mail http://codereview.chromium.org/3152055/diff/25002/27005 File chrome/browser/browser_about_handler.cc (right): http://codereview.chromium.org/3152055/diff/25002/27005#newcode258 chrome/browser/browser_about_handler.cc:258: if (kAllAboutPaths[i] == ...
10 years, 3 months ago (2010-08-27 00:06:40 UTC) #3
viettrungluu
Have you checked if about:labs lays out correctly in RTL languages? +arv to look over ...
10 years, 3 months ago (2010-08-27 02:52:16 UTC) #4
Nico
Thanks. Arv is on vacation I believe, so I won't wait for him. Haven't checked ...
10 years, 3 months ago (2010-08-27 03:21:05 UTC) #5
viettrungluu
On 2010/08/27 03:21:05, Nico wrote: > Thanks. > > Arv is on vacation I believe, ...
10 years, 3 months ago (2010-08-27 03:27:32 UTC) #6
viettrungluu
Argh. "Reply" doesn't send drafts. I also forgot to add the all-important "ship it" (a.k.a. ...
10 years, 3 months ago (2010-08-27 03:28:45 UTC) #7
viettrungluu
10 years, 3 months ago (2010-08-27 03:31:14 UTC) #8
http://codereview.chromium.org/3152055/diff/34001/35013
File chrome/browser/labs.h (right):

http://codereview.chromium.org/3152055/diff/34001/35013#newcode15
chrome/browser/labs.h:15: namespace Labs {
On 2010/08/27 03:21:06, Nico wrote:
> On 2010/08/27 02:52:16, viettrungluu wrote:
> > I don't think we ever capitalize namespace names, do we?
> 
> I guess not.
> 
> I'm always unsure if we prefer classes with static methods or namespaces for
> things like this. Namespaces seem superior, but lots of places have classes,
so
> this was my unconscious attempt at a compromise :-P
> 
> done

Yeah, that occurred to me later. I'm torn, since lowercase namespaces are
generally reserved for pretty general things. (And it's moderately silly to have
a class with only static methods. Maybe I would have liked it more if it had a
longer name, like LabsExperiments. <shrug>)

Powered by Google App Engine
This is Rietveld 408576698