Issue 3244006: Merge 55669 - Clamp the hotspot on custom cursors to the custom cursor image'...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3244006: Merge 55669 - Clamp the hotspot on custom cursors to the custom cursor image'... (Closed)

Created:
10 years, 3 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Description

Merge 55669 - Clamp the hotspot on custom cursors to the custom cursor image's dimensions. Current behavior: windows chrome - respect the crazy hotspot linux chrome - crash mac chrome - fall back to normal cursor firefox - clamp the hotspot to the custom cursor image bounds. So this unifies the behavior of all 3 chrome platforms and matches firefox. BUG=51709 TEST=see bug for reduction Review URL: http://codereview.chromium.org/3168003 TBR=estade@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58016

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -0 lines)			Patch
M	webkit/glue/webcursor.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webcursor.cc	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	webkit/glue/webcursor_unittest.cc	View	2 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages