Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 3168003: Clamp the hotspot on custom cursors to the custom cursor image. (Closed)

Created:
10 years, 4 months ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Clamp the hotspot on custom cursors to the custom cursor image's dimensions. Current behavior: windows chrome - respect the crazy hotspot linux chrome - crash mac chrome - fall back to normal cursor firefox - clamp the hotspot to the custom cursor image bounds. So this unifies the behavior of all 3 chrome platforms and matches firefox. BUG=51709 TEST=see bug for reduction Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55669

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M webkit/glue/webcursor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/webcursor.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M webkit/glue/webcursor_unittest.cc View 2 chunks +36 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Evan Stade
10 years, 4 months ago (2010-08-10 23:36:58 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/3168003/diff/1/4 File webkit/glue/webcursor_unittest.cc (right): http://codereview.chromium.org/3168003/diff/1/4#newcode105 webkit/glue/webcursor_unittest.cc:105: ASSERT_TRUE(custom_cursor.Deserialize(&ok_custom_pickle, &iter)); yay correct usage of assert
10 years, 4 months ago (2010-08-11 00:01:58 UTC) #2
darin (slow to review)
10 years, 4 months ago (2010-08-14 06:46:16 UTC) #3
LGTM2

Powered by Google App Engine
This is Rietveld 408576698