Issue 3278002: Rename webcore to 'webcore_remaining'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3278002: Rename webcore to 'webcore_remaining'. (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Victor Wang

Base URL:
git://git.webkit.org/WebKit.git

Visibility:
Public.

Description

Rename webcore to 'webcore_remaining'. Create a meta-target webcore that inherits from every webcore_XXX targets. (Currently 1) Move direct_dependent_settings and export_dependent_settings from webcore_remaining to webcore Obviously, there will be other webcore_XXX targets. Keeping the change as small as possible. depends on http://codereview.chromium.org/3215004 is https://bugs.webkit.org/show_bug.cgi?id=44796

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -34 lines)			Patch
	M	WebCore/WebCore.gyp/WebCore.gyp	View		6 chunks	+54 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://build.chromium.org/buildbot/try-server/builders/win/builds/47125 http://build.chromium.org/buildbot/try-server/builders/win/builds/47124 http://build.chromium.org/buildbot/try-server/builders/mac/builds/44318 http://build.chromium.org/buildbot/try-server/builders/mac/builds/44319 http://build.chromium.org/buildbot/try-server/builders/linux/builds/44441 http://build.chromium.org/buildbot/try-server/builders/linux/builds/44442 I sent a few jobs to make sure it'd ...

10 years, 3 months ago (2010-08-27 21:23:57 UTC) #1

Victor Wang

10 years, 3 months ago (2010-08-27 21:33:14 UTC) #3

LGTM

On 2010/08/27 21:23:57, Marc-Antoine Ruel wrote:
> http://build.chromium.org/buildbot/try-server/builders/win/builds/47125
> http://build.chromium.org/buildbot/try-server/builders/win/builds/47124
> 
> http://build.chromium.org/buildbot/try-server/builders/mac/builds/44318
> http://build.chromium.org/buildbot/try-server/builders/mac/builds/44319
> 
> http://build.chromium.org/buildbot/try-server/builders/linux/builds/44441
> http://build.chromium.org/buildbot/try-server/builders/linux/builds/44442
> 
> I sent a few jobs to make sure it'd work with both incremental and full
builds.

Expand Messages | Collapse Messages