Make Pepper NPN variable return a pointer to an allocated...

Make Pepper NPN variable return a pointer to an allocated
structure rather than using several variables.  Added a stub
DestroyRendererContext function.  Updates the test to work with
the changes.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30213

[sehr (please use chromium), 2009-10-22 18:58:50]

Apropos our discussion with Al about adding further extensions.

[jam, 2009-10-22 20:28:52]

lgtm

http://codereview.chromium.org/322003/diff/1/2
File webkit/glue/plugins/plugin_host.cc (right):

http://codereview.chromium.org/322003/diff/1/2#newcode866
Line 866:
reinterpret_cast<NPPepperExtensions*>(NPN_MemAlloc(sizeof(*extensions)));
nit: need two more spaces

[brettw, 2009-10-22 20:32:19]

LGTM. Can you hold off on checking this in? I've been repeatedly sending my
patch to the trybots all day and I'd like to avoid a conflict.

[sehr (please use chromium), 2009-10-22 20:41:25]

NP.  Will fix and wait for your signal.

On Thu, Oct 22, 2009 at 1:32 PM, <brettw@chromium.org> wrote:

> LGTM. Can you hold off on checking this in? I've been repeatedly sending my
> patch to the trybots all day and I'd like to avoid a conflict.
>
>
> http://codereview.chromium.org/322003
>

[sehr (please use chromium), 2009-10-22 22:02:40]

Fixed and still waiting.

http://codereview.chromium.org/322003/diff/1/2
File webkit/glue/plugins/plugin_host.cc (right):

http://codereview.chromium.org/322003/diff/1/2#newcode866
Line 866:
reinterpret_cast<NPPepperExtensions*>(NPN_MemAlloc(sizeof(*extensions)));
On 2009/10/22 20:28:52, John Abd-El-Malek wrote:
> nit: need two more spaces

Done.

[brettw, 2009-10-26 21:43:55]

http://codereview.chromium.org/322003/diff/7002/7003
File webkit/glue/plugins/plugin_host.cc (right):

http://codereview.chromium.org/322003/diff/7002/7003#newcode866
Line 866: NPN_MemAlloc(sizeof(*extensions)));
I don't understand the memory management around this. I don't see other types of
getters return an allocated pointer, and I don't see how it's getting freed.

[sehr (please use chromium), 2009-10-26 21:58:51]

Updated again.

http://codereview.chromium.org/322003/diff/7002/7003
File webkit/glue/plugins/plugin_host.cc (right):

http://codereview.chromium.org/322003/diff/7002/7003#newcode866
Line 866: NPN_MemAlloc(sizeof(*extensions)));
On 2009/10/26 21:43:55, brettw wrote:
> I don't understand the memory management around this. I don't see other types
of
> getters return an allocated pointer, and I don't see how it's getting freed.

Ok, I've made it return a pointer to the canonical array.

[sehr (please use chromium), 2009-10-26 23:10:30]

And after chasing a trybot/chromebot version skew, things seem to be working
again...

On 2009/10/26 21:58:51, sehr wrote:
> Updated again.
> 
> http://codereview.chromium.org/322003/diff/7002/7003
> File webkit/glue/plugins/plugin_host.cc (right):
> 
> http://codereview.chromium.org/322003/diff/7002/7003#newcode866
> Line 866: NPN_MemAlloc(sizeof(*extensions)));
> On 2009/10/26 21:43:55, brettw wrote:
> > I don't understand the memory management around this. I don't see other
types
> of
> > getters return an allocated pointer, and I don't see how it's getting freed.
> 
> Ok, I've made it return a pointer to the canonical array.

[brettw, 2009-10-26 23:13:38]

LGTM

http://codereview.chromium.org/322003/diff/9003/6005
File webkit/glue/plugins/plugin_host.cc (right):

http://codereview.chromium.org/322003/diff/9003/6005#newcode866
Line 866: // Make a copy of the canonical function table.
Nit: fix comment (you don't copy anymore).