Issue 3212005: Unify sidebar identification in the chrome.experimental.sidebar extension API...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3212005: Unify sidebar identification in the chrome.experimental.sidebar extension API... (Closed)

Created:
10 years, 3 months ago by alekseys

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Unify sidebar identification in the chrome.experimental.sidebar extension API implementation. BUG=51084 TEST=Run interactive_ui_tests and browser_tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57965

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -14 lines)			Patch
M	chrome/browser/extensions/extension_sidebar_api.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_sidebar_api.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sidebar/sidebar_container.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/sidebar/sidebar_container.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/sidebar/sidebar_manager.cc	View	3 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm