Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/sidebar/sidebar_manager.cc

Issue 3212005: Unify sidebar identification in the chrome.experimental.sidebar extension API... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sidebar/sidebar_container.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sidebar/sidebar_manager.cc
===================================================================
--- chrome/browser/sidebar/sidebar_manager.cc (revision 57122)
+++ chrome/browser/sidebar/sidebar_manager.cc (working copy)
@@ -83,14 +83,14 @@
if (was_active_host != NULL) {
ExtensionSidebarEventRouter::OnStateChanged(
was_active_sidebar_contents->profile(),
- was_active_host->GetTabId(), was_active_host->content_id(),
+ was_active_host->tab_contents(), was_active_host->content_id(),
extension_sidebar_constants::kShownState);
}
if (active_host != NULL) {
ExtensionSidebarEventRouter::OnStateChanged(
active_sidebar_contents->profile(),
- active_host->GetTabId(), active_host->content_id(),
+ active_host->tab_contents(), active_host->content_id(),
extension_sidebar_constants::kActiveState);
}
}
@@ -107,7 +107,7 @@
host->Show();
ExtensionSidebarEventRouter::OnStateChanged(
- tab->profile(), host->GetTabId(), content_id,
+ tab->profile(), tab, content_id,
extension_sidebar_constants::kShownState);
}
@@ -160,12 +160,11 @@
SidebarContainer* host = GetSidebarContainerFor(tab, content_id);
DCHECK(host);
- int tab_id = host->GetTabId();
UnregisterSidebarContainerFor(tab, content_id);
ExtensionSidebarEventRouter::OnStateChanged(
- tab->profile(), tab_id, content_id,
+ tab->profile(), tab, content_id,
extension_sidebar_constants::kHiddenState);
}
« no previous file with comments | « chrome/browser/sidebar/sidebar_container.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698