Issue 3211004: Revert 57572 - Remove the default argument from RegKey::Open....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3211004: Revert 57572 - Remove the default argument from RegKey::Open.... (Closed)

Created:
10 years, 4 months ago by chase

Modified:
9 years, 7 months ago

Reviewers:
tfarina

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 57572 - Remove the default argument from RegKey::Open. Caused a failure on Windows Chromium Builder (dbg): ...\configuration_policy_provider_win.cc(71) : error C2660: 'RegKey::Open' : function does not take 2 arguments BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Review URL: http://codereview.chromium.org/3205007 TBR=tfarina@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57575

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -11 lines)			Patch
M	base/registry.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_rlz_apitest.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/external_registry_extension_provider_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
MM	chrome/browser/platform_util_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl_win.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages