Issue 3205007: Remove the default argument from RegKey::Open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3205007: Remove the default argument from RegKey::Open. (Closed)

Created:
10 years, 4 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, brettw-cc_chromium.org, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Remove the default argument from RegKey::Open. BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57572

Patch Set 1 #

Patch Set 2 : fix webkit #

Patch Set 3 : fixes for chrome/browser/ #

Patch Set 4 : fixes for extensions #

Total comments: 2

Patch Set 5 : fix nit #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
M	base/registry.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_rlz_apitest.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/external_registry_extension_provider_win.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/platform_util_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider_win.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl_win.cc	View	2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm with one style nit http://codereview.chromium.org/3205007/diff/7001/8006 File webkit/glue/plugins/webplugin_delegate_impl_win.cc (right): http://codereview.chromium.org/3205007/diff/7001/8006#newcode416 webkit/glue/plugins/webplugin_delegate_impl_win.cc:416: KEY_READ) && !g_iat_patch_reg_enum_key_ex_w.Pointer()->is_patched()) { ...

10 years, 4 months ago (2010-08-26 15:53:12 UTC) #2

tfarina

10 years, 4 months ago (2010-08-26 16:21:54 UTC) #3

http://codereview.chromium.org/3205007/diff/7001/8006
File webkit/glue/plugins/webplugin_delegate_impl_win.cc (right):

http://codereview.chromium.org/3205007/diff/7001/8006#newcode416
webkit/glue/plugins/webplugin_delegate_impl_win.cc:416: KEY_READ) &&
!g_iat_patch_reg_enum_key_ex_w.Pointer()->is_patched()) {
On 2010/08/26 15:53:13, Marc-Antoine Ruel wrote:
> you should realign !g_... on the next line since it's not inside the Open()
> function call.

Done.

Expand Messages | Collapse Messages