Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 3207002: FBTF: Forward declare and move constructors in chrome/common/extensions/. (Closed)

Created:
10 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, idana, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing), John Grabowski
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

FBTF: Forward declare and move constructors in chrome/common/extensions/. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57543

Patch Set 1 #

Patch Set 2 : rebase + mac fixes #

Patch Set 3 : Win fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -61 lines) Patch
M chrome/browser/automation/automation_provider.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_theme_pack.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browser_actions_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_module.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_metrics_module.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_popup_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_rlz_module.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/external_pref_extension_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension.h View 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/common/extensions/extension.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_extent.h View 1 chunk +10 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension_extent.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_file_util.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_message_bundle.h View 2 chunks +5 lines, -16 lines 0 comments Download
M chrome/common/extensions/extension_message_bundle.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_unpacker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_unpacker.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/common/extensions/update_manifest.h View 1 chunk +0 lines, -1 line 1 comment Download
M chrome/common/extensions/url_pattern.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/url_pattern.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/url_pattern_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/user_script.h View 4 chunks +9 lines, -16 lines 0 comments Download
M chrome/common/extensions/user_script.cc View 4 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
AA: I saw your post in evanm's buzz on binary size, and since I'm devoting ...
10 years, 4 months ago (2010-08-25 18:45:32 UTC) #1
Lei Zhang
Mostly LGTM, but I'll let aa have the final say. http://codereview.chromium.org/3207002/diff/26/6021 File chrome/common/extensions/update_manifest.h (left): http://codereview.chromium.org/3207002/diff/26/6021#oldcode12 ...
10 years, 4 months ago (2010-08-25 20:03:04 UTC) #2
Aaron Boodman
10 years, 4 months ago (2010-08-26 00:07:42 UTC) #3
This is great. Thanks for the fixes. LGTM

Powered by Google App Engine
This is Rietveld 408576698