Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6455)

Unified Diff: chrome/common/extensions/extension.h

Issue 3207002: FBTF: Forward declare and move constructors in chrome/common/extensions/. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Win fixes Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 9c51d1a2aa3973b15718575c55d91186f6b3b5af..81b387e9d6ee15f6edaf13f204274a368dba106f 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -14,13 +14,13 @@
#include "base/file_path.h"
#include "base/gtest_prod_util.h"
#include "base/scoped_ptr.h"
-#include "base/values.h"
#include "chrome/common/extensions/extension_extent.h"
#include "chrome/common/extensions/user_script.h"
#include "chrome/common/extensions/url_pattern.h"
#include "gfx/size.h"
#include "googleurl/src/gurl.h"
+class DictionaryValue;
class ExtensionAction;
class ExtensionResource;
class SkBitmap;
@@ -596,14 +596,8 @@ struct ExtensionInfo {
ExtensionInfo(const DictionaryValue* manifest,
const std::string& id,
const FilePath& path,
- Extension::Location location)
- : extension_id(id),
- extension_path(path),
- extension_location(location) {
- if (manifest)
- extension_manifest.reset(
- static_cast<DictionaryValue*>(manifest->DeepCopy()));
- }
+ Extension::Location location);
+ ~ExtensionInfo();
scoped_ptr<DictionaryValue> extension_manifest;
std::string extension_id;

Powered by Google App Engine
This is Rietveld 408576698