chrome/browser/policy/configuration_policy_provider_win.cc - Issue 3205007: Remove the default argument from RegKey::Open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/configuration_policy_provider_win.cc

Issue 3205007: Remove the default argument from RegKey::Open. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: fix nit Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/policy/configuration_policy_provider_win.cc

diff --git a/chrome/browser/policy/configuration_policy_provider_win.cc b/chrome/browser/policy/configuration_policy_provider_win.cc

index 2e5904e6ed5ba821ba22a8a8e5e1bb40768dd6f7..20b8f644af217113b3b33b6d4c6718d7d399506e 100644

--- a/chrome/browser/policy/configuration_policy_provider_win.cc

+++ b/chrome/browser/policy/configuration_policy_provider_win.cc

@@ -73,11 +73,11 @@ bool ConfigurationPolicyProviderWin::GetRegistryPolicyString(

}

// First try the global policy.

- if (!policy_key.Open(HKEY_LOCAL_MACHINE, location.c_str()) ||

+ if (!policy_key.Open(HKEY_LOCAL_MACHINE, location.c_str(), KEY_READ) ||

!policy_key.ReadValue(value_name.c_str(), 0, &value_size, &key_type)) {

policy_key.Close();

// Fall back on user-specific policy.

- if (!policy_key.Open(HKEY_CURRENT_USER, location.c_str()) ||

+ if (!policy_key.Open(HKEY_CURRENT_USER, location.c_str(), KEY_READ) ||

!policy_key.ReadValue(value_name.c_str(), 0, &value_size, &key_type)) {

return false;

}