Issue 3204003: Check that BlockedContents::blocked_popup_container is not NULL before using ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3204003: Check that BlockedContents::blocked_popup_container is not NULL before using ... (Closed)

Created:
10 years, 4 months ago by jschuh

Modified:
9 years, 6 months ago

Reviewers:
inferno

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Check that BlockedContents::blocked_popup_container is not NULL before using it. BUG=53176 TEST=None. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57249

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/content_setting_bubble_model.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

inferno

10 years, 4 months ago (2010-08-24 21:25:49 UTC) #1

LGTM pending trybots run green.

http://codereview.chromium.org/3204003/diff/1/2
File chrome/browser/content_setting_bubble_model.cc (right):

http://codereview.chromium.org/3204003/diff/1/2#newcode323
chrome/browser/content_setting_bubble_model.cc:323: return;
You can put this at start of function. no need to have blocked_contents declared
if we need to return.

Do we want to check null tabcontents(). I do see it used in a similar context
here -
https://cs/p#chrome/trunk/src/chrome/browser/content_setting_bubble_model.cc&...

Optional - please put a line comment explaining this and link to crbug.com.

Expand Messages | Collapse Messages