Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5385)

Unified Diff: chrome/browser/content_setting_bubble_model.cc

Issue 3204003: Check that BlockedContents::blocked_popup_container is not NULL before using ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_setting_bubble_model.cc
===================================================================
--- chrome/browser/content_setting_bubble_model.cc (revision 57221)
+++ chrome/browser/content_setting_bubble_model.cc (working copy)
@@ -318,8 +318,10 @@
private:
void SetPopups() {
+ // check for crbug.com/53176
+ if (!tab_contents()->blocked_popup_container())
+ return;
BlockedPopupContainer::BlockedContents blocked_contents;
- DCHECK(tab_contents()->blocked_popup_container());
tab_contents()->blocked_popup_container()->GetBlockedContents(
&blocked_contents);
for (BlockedPopupContainer::BlockedContents::const_iterator
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698