net/proxy/proxy_script_fetcher_unittest.cc - Issue 320003: Refactor: Don't send the quit command before killing test server for ProxyScr...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_script_fetcher_unittest.cc

Issue 320003: Refactor: Don't send the quit command before killing test server for ProxyScr... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_script_fetcher_unittest.cc

===================================================================

--- net/proxy/proxy_script_fetcher_unittest.cc (revision 29714)

+++ net/proxy/proxy_script_fetcher_unittest.cc (working copy)

@@ -193,8 +193,7 @@

}

// Now kill the HTTP server.

- server->SendQuit();

- EXPECT_TRUE(server->WaitToFinish(20000));

+ EXPECT_TRUE(server->Stop()); // Verify it shutdown synchronously.

wtc 2009/10/22 21:38:58 Nit: shutdown => shut down (past tense?)

server = NULL;

// Try to fetch the file again -- if should fail, since the server is not

« no previous file with comments | « no previous file | no next file » | no next file with comments »