Refactor: Don't send the quit command before killing test server for ProxyScr...

net/proxy/proxy_script_fetcher_unittest.cc

 // Copyright (c) 2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_script_fetcher.h"
 
 #include "base/file_path.h"
 #include "base/compiler_specific.h"
 #include "base/path_service.h"
 #include "net/base/net_util.h"
@@ skipping 175 matching lines @@
   {
     std::string bytes;
     TestCompletionCallback callback;
     int result = pac_fetcher->Fetch(url, &bytes, &callback);
     EXPECT_EQ(ERR_IO_PENDING, result);
     EXPECT_EQ(OK, callback.WaitForResult());
     EXPECT_EQ("-cacheable_1hr.pac-\n", bytes);
   }
 
   // Now kill the HTTP server.
-  server->SendQuit();
-  EXPECT_TRUE(server->WaitToFinish(20000));
+  EXPECT_TRUE(server->Stop());  // Verify it shutdown synchronously.

[wtc, 2009/10/22 21:38:58]

Nit: shutdown => shut down (past tense?)

   server = NULL;
 
   // Try to fetch the file again -- if should fail, since the server is not
   // running anymore. (If it were instead being loaded from cache, we would
   // get a success.
   {
     std::string bytes;
     TestCompletionCallback callback;
     int result = pac_fetcher->Fetch(url, &bytes, &callback);
     EXPECT_EQ(ERR_IO_PENDING, result);
@@ skipping 110 matching lines @@
     std::string bytes;
     TestCompletionCallback callback;
     int result = pac_fetcher->Fetch(url, &bytes, &callback);
     EXPECT_EQ(ERR_IO_PENDING, result);
     EXPECT_EQ(OK, callback.WaitForResult());
     EXPECT_EQ("This was encoded as UTF-16BE.\n", bytes);
   }
 }
 
 }  // namespace net