Revert 57100 - Only create the backup ConnectJob when it is needed....

Revert 57100 - Only create the backup ConnectJob when it is needed.
This reduces the unnecessary NetLog spam, since we would log to the NetLog everytime we created the backup ConnectJob, even though we usually wouldn't actually call Connect() on it.  Now, we only create the backup ConnectJob when we intend to call Connect() on it.
Includes some various cleanup necessary for this:
  * struct Group => class Group
  * method_factory moves from CSP to Group

Review URL: http://codereview.chromium.org/3171017

TBR=willchan@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57107

[Lei Zhang, 2010-08-23 20:40:44]

modules xp:

[ RUN      ] HttpNetworkTransactionTest.UseAlternateProtocolForTunneledNpnSpdy
Backtrace:
	net::internal::ClientSocketPoolBaseHelper::CancelAllConnectJobs
[0x008890C4+100]
(c:\b\slave\sub-rel-xp\build\src\net\socket\client_socket_pool_base.cc:713)
	kSOCKS5GreetWriteData [0x00BFD674+1300]
	net::internal::ClientSocketPoolBaseHelper::OnConnectJobComplete [0x0088A7E0+0]
(c:\b\slave\sub-rel-xp\build\src\net\socket\client_socket_pool_base.cc:557)
	(No symbol) [0xFFFFFCB8]


modules vista dbg:


[----------] 1 test from SpdyStreamTest
[ RUN      ] SpdyStreamTest.SendDataAfterOpen
[27188:130664:0823/131017:2638139500:ERROR:spdy_session.cc(803)] ABANDONED
(stream_id=1): /

command timed out: 600 seconds without output, killing pid 66012

[willchan no longer on Chromium, 2010-08-23 21:45:35]

Blargh, sorry.  Thanks for reverting!

On Mon, Aug 23, 2010 at 1:40 PM, <thestig@chromium.org> wrote:

> modules xp:
>
> [ RUN      ]
> HttpNetworkTransactionTest.UseAlternateProtocolForTunneledNpnSpdy
> Backtrace:
>        net::internal::ClientSocketPoolBaseHelper::CancelAllConnectJobs
> [0x008890C4+100]
> (c:\b\slave\sub-rel-xp\build\src\net\socket\client_socket_pool_base.cc:713)
>        kSOCKS5GreetWriteData [0x00BFD674+1300]
>        net::internal::ClientSocketPoolBaseHelper::OnConnectJobComplete
> [0x0088A7E0+0]
> (c:\b\slave\sub-rel-xp\build\src\net\socket\client_socket_pool_base.cc:557)
>        (No symbol) [0xFFFFFCB8]
>
>
> modules vista dbg:
>
>
> [----------] 1 test from SpdyStreamTest
> [ RUN      ] SpdyStreamTest.SendDataAfterOpen
> [27188:130664:0823/131017:2638139500:ERROR:spdy_session.cc(803)] ABANDONED
> (stream_id=1): /
>
> command timed out: 600 seconds without output, killing pid 66012
>
>
> http://codereview.chromium.org/3198009/show
>