Issue 3198001: Fix leaks in GoogleURLTrackerTest::CreateRequestContext()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3198001: Fix leaks in GoogleURLTrackerTest::CreateRequestContext() (Closed)

Created:
10 years, 4 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Yuta Kitamura, Hironori Bono

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Fix leaks in GoogleURLTrackerTest::CreateRequestContext() URLFetcher will release URLRequestContextGetter in CancelURLRequest, which runs in IOMessageLoopProxy. So, if a test doesn't run with IO thread, it will not run CancelURLRequest from URLFetcher::Core::Stop(). BUG=52562 TEST=./tools/valgrind/chrome_tests.sh --test unit --tool memcheck --gtest_filter='GoogleURLTrackerTest.*' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56522

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	chrome/browser/google_url_tracker_unittest.cc	View		3 chunks	+5 lines, -4 lines	0 comments	Download
	M	chrome/common/net/test_url_fetcher_factory.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Regards,

Hironori Bono

Expand Messages | Collapse Messages