Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/common/net/test_url_fetcher_factory.h

Issue 3198001: Fix leaks in GoogleURLTrackerTest::CreateRequestContext() (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/google_url_tracker_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/net/test_url_fetcher_factory.h
diff --git a/chrome/common/net/test_url_fetcher_factory.h b/chrome/common/net/test_url_fetcher_factory.h
index 3d8646677eb68140a94d4411f012dd6aed542df2..f2a5acfcc359b8db5d69b31f237413551fa14b7c 100644
--- a/chrome/common/net/test_url_fetcher_factory.h
+++ b/chrome/common/net/test_url_fetcher_factory.h
@@ -20,7 +20,9 @@
// URLFetcher.
// Typical usage:
// // TestURLFetcher requires a MessageLoop:
-// MessageLoopForUI message_loop;
+// MessageLoopForIO message_loop;
+// // and IO thread to clean up request_context etc.
+// ChromeThread io_thread(ChromeThread::IO, &message_loop);
// // Create and register factory.
// TestURLFetcherFactory factory;
// URLFetcher::set_factory(&factory);
« no previous file with comments | « chrome/browser/google_url_tracker_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698