Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 3197024: Fix problem with crash_sender being able to run multiple times concurrently. (Closed)

Created:
10 years, 4 months ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Fix problem with crash_sender being able to run multiple times concurrently. BUG=6134 TEST=Run CrashSender and UserCrash, also test starting those tests while crash_sender is already running. Change-Id: Ie80c450f6b0da1b67398aa67fd9b74903abc430b

Patch Set 1 #

Patch Set 2 : Guarantee exclusive running of crash_sender #

Total comments: 1

Patch Set 3 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M crash_sender View 1 2 4 chunks +25 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kmixter1
10 years, 4 months ago (2010-08-26 23:00:17 UTC) #1
petkov-google
LGTM but you still have a race, right? If you start two processes in parallel ...
10 years, 4 months ago (2010-08-26 23:09:21 UTC) #2
petkov
On 2010/08/26 23:09:21, petkov-google wrote: > LGTM but you still have a race, right? If ...
10 years, 4 months ago (2010-08-26 23:11:29 UTC) #3
petkov
See below. http://codereview.chromium.org/3197024/diff/5001/6001 File crash_sender (right): http://codereview.chromium.org/3197024/diff/5001/6001#newcode82 crash_sender:82: echo $$ > "${RUN_FILE}" You still have ...
10 years, 4 months ago (2010-08-27 00:55:00 UTC) #4
petkov
10 years, 4 months ago (2010-08-27 01:00:55 UTC) #5
LGTM based on discussion (maybe add a comment).

Powered by Google App Engine
This is Rietveld 408576698