Fix problem with crash_sender being able to run multiple times concurrently.

crash_sender

 #!/bin/sh
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 set -e
 
 # Product ID in crash report
 CHROMEOS_PRODUCT=ChromeOS
 
+# Should remove the run file when this process finishes.  We don't want
+# to always remove it since it may be for pre-existing crash_sender
+# process.
+CLEAN_UP_RUN_FILE=0
+
 # File whose existence implies crash reports may be sent, and whose
 # contents includes our machine's anonymized guid.
 CONSENT_ID="/home/chronos/Consent To Send Stats"
 
 # Path to find which is required for computing the crash rate.
 FIND="/usr/bin/find"
 
 # Send up to 8 crashes per day.
 MAX_CRASH_RATE=8
 
@@ skipping 17 matching lines @@
 # Maximum time to sleep between sends.
 SECONDS_SEND_SPREAD=${SECONDS_SEND_SPREAD:-600}
 
 # The syslog tag for all logging we emit.
 TAG="$(basename $0)[$$]"
 
 # Directory to store timestamp files indicating the uploads in the past 24
 # hours.
 TIMESTAMPS_DIR="/var/lib/crash_sender"
 
+# Temp directory for this process.
+TMP_DIR=""
+
 lecho() {
   logger -t "${TAG}" "$@"
 }
 
-cleanup_tmp_dir() {
-  rm -rf "${TMP_DIR}"
-}
-
-cleanup_run_file_and_tmp_dir() {
-  rm -f "${RUN_FILE}"
-  cleanup_tmp_dir
+cleanup() {
+  if [ -n "${TMP_DIR}" ]; then
+    rm -rf "${TMP_DIR}"
+  fi
+  if [ ${CLEAN_UP_RUN_FILE} -eq 1 ]; then
+    rm -f "${RUN_FILE}"
+  fi
 }
 
 check_not_already_running() {
-  if [ ! -f "${RUN_FILE}" ]; then
+  set -o noclobber
+  if echo $$ 2>/dev/null > "${RUN_FILE}"; then
+    # Able to write RUN_FILE without contention.
+    CLEAN_UP_RUN_FILE=1
+    set +o noclobber
     return
   fi
+  set +o noclobber
   local last_pid=$(cat "${RUN_FILE}")
   if [ ! -f "/proc/${last_pid}/cmdline" ]; then
-    trap cleanup_run_file_and_tmp_dir EXIT INT
+    CLEAN_UP_RUN_FILE=1
+    # Note that this write may be executed by two crash_senders who
+    # simulataneously reap the existing dangling run file
     echo $$ > "${RUN_FILE}"
     return
   fi
   # This could just be an unrelated process, but it's ok to be conservative.
   lecho "Already running.  Exiting now."
   exit 1
 }
 
 get_version() {
   grep ^CHROMEOS_RELEASE_VERSION /etc/lsb-release | cut -d = -f 2-
@@ skipping 147 matching lines @@
       # Send was successful, now remove
       lecho "Successfully sent crash ${report_path} and removing"
       rm "${report_path}"
     else
       lecho "Problem sending ${report_path}, not removing"
     fi
   done
 }
 
 main() {
+  trap cleanup EXIT INT TERM
   if [ -e "${PAUSE_CRASH_SENDING}" ]; then
     lecho "Exiting early due to ${PAUSE_CRASH_SENDING}"
     exit 1
   fi
 
   check_not_already_running
 
   if [ ! -x "${FIND}" ]; then
     lecho "Fatal: Crash sending disabled: ${FIND} not found."
     exit 1
   fi
 
   TMP_DIR="$(mktemp -d /tmp/crash_sender.XXXX)"
-  trap cleanup_tmp_dir EXIT INT
 
   # Send system-wide crashes
   send_crashes "/var/spool/crash"
 
   # Send user-specific crashes
   send_crashes "/home/chronos/user/crash"
 }
 
 main