Issue 3192011: Make sure the key into the spdy session pool identifies the actual proxy used...

Issue 3192011: Make sure the key into the spdy session pool identifies the actual proxy used... (Closed)

Created:
10 years, 4 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make sure the key into the spdy session pool identifies the actual proxy used, and not the full list of possible proxies for the URL. BUG=52668 TEST=SpdyNetworkTransactionTest.DirectConnectProxyReconnect Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57274

Patch Set 1 #

Patch Set 2 : rework some comments #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -22 lines)			Patch
M	net/http/http_stream_request.cc	View		2 chunks	+3 lines, -2 lines	2 comments	Download
M	net/proxy/proxy_info.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/proxy/proxy_service.h	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/proxy/proxy_service.cc	View	1	2 chunks	+48 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_network_transaction_unittest.cc	View		4 chunks	+17 lines, -7 lines	0 comments	Download
M	net/spdy/spdy_test_util.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	net/spdy/spdy_test_util.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

LGTM http://codereview.chromium.org/3192011/diff/9001/10001 File net/http/http_stream_request.cc (right): http://codereview.chromium.org/3192011/diff/9001/10001#newcode426 net/http/http_stream_request.cc:426: HostPortProxyPair pair(endpoint_, proxy_info()->proxy_server().ToPacString()); Because HostPortProxyPair takes a string, ...

10 years, 4 months ago (2010-08-24 15:19:58 UTC) #2

eroman

10 years, 4 months ago (2010-08-25 01:34:57 UTC) #3

http://codereview.chromium.org/3192011/diff/9001/10001
File net/http/http_stream_request.cc (right):

http://codereview.chromium.org/3192011/diff/9001/10001#newcode426
net/http/http_stream_request.cc:426: HostPortProxyPair pair(endpoint_,
proxy_info()->proxy_server().ToPacString());
On 2010/08/24 15:19:58, Mike Belshe wrote:
> Because HostPortProxyPair takes a string, this bug is possible.  Perhaps, if
it
> took a const ProxyServer& instead, type checking would prevent this bug from
> happening again?

Indeed, that is a very good idea.

I will do a follow-up CL which refactors it to being a ProxyServer.

Expand Messages | Collapse Messages