Make sure the key into the spdy session pool identifies the actual proxy used...

net/http/http_stream_request.cc

Index: net/http/http_stream_request.cc
===================================================================
--- net/http/http_stream_request.cc	(revision 57108)
+++ net/http/http_stream_request.cc	(working copy)
@@ -423,7 +423,7 @@
 
   // Check first if we have a spdy session for this group.  If so, then go
   // straight to using that.
-  HostPortProxyPair pair(endpoint_, proxy_info()->ToPacString());
+  HostPortProxyPair pair(endpoint_, proxy_info()->proxy_server().ToPacString());

[Mike Belshe, 2010/08/24 15:19:58]

Because HostPortProxyPair takes a string, this bug is possible.  Perhaps, if it
took a const ProxyServer& instead, type checking would prevent this bug from
happening again?

[eroman, 2010/08/25 01:34:57]

Indeed, that is a very good idea.

I will do a follow-up CL which refactors it to being a ProxyServer.

   if (session_->spdy_session_pool()->HasSession(pair)) {
     using_spdy_ = true;
     next_state_ = STATE_INIT_STREAM;
@@ -687,7 +687,8 @@
       session_->spdy_session_pool();
   scoped_refptr<SpdySession> spdy_session;
 
-  HostPortProxyPair pair(endpoint_, proxy_info()->ToPacString());
+  HostPortProxyPair pair(endpoint_,
+                         proxy_info()->proxy_server().ToPacString());
   if (session_->spdy_session_pool()->HasSession(pair)) {
     spdy_session =
         session_->spdy_session_pool()->Get(pair, session_, net_log_);