Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/browser/dom_ui/advanced_options_handler.cc

Issue 3190004: dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Rebase to r56963. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/advanced_options_handler.cc
===================================================================
--- chrome/browser/dom_ui/advanced_options_handler.cc (revision 56963)
+++ chrome/browser/dom_ui/advanced_options_handler.cc (working copy)
@@ -218,11 +218,15 @@
void AdvancedOptionsHandler::FileSelected(const FilePath& path, int index,
void* params) {
+ UserMetricsRecordAction(UserMetricsAction("Options_SetDownloadDirectory"),
+ NULL);
default_download_location_.SetValue(path);
SetupDownloadLocationPath();
}
void AdvancedOptionsHandler::HandleAutoOpenButton(const ListValue* args) {
+ UserMetricsRecordAction(UserMetricsAction("Options_ResetAutoOpenFiles"),
+ NULL);
DCHECK(dom_ui_);
DownloadManager* manager = dom_ui_->GetProfile()->GetDownloadManager();
if (manager) manager->ResetAutoOpenFiles();
@@ -231,12 +235,20 @@
#if defined(OS_WIN)
void AdvancedOptionsHandler::HandleCheckRevocationCheckbox(
const ListValue* args) {
+ UserMetricsRecordAction(UserMetricsAction(metric.c_str()), NULL);
std::string checked_str = WideToUTF8(ExtractStringValue(args));
+ std::string metric =
+ (checked_str == "true" ? "Options_CheckCertRevocation_Enable"
+ : "Options_CheckCertRevocation_Disable");
net::SSLConfigServiceWin::SetRevCheckingEnabled(checked_str == "true");
}
void AdvancedOptionsHandler::HandleUseSSL2Checkbox(const ListValue* args) {
+ UserMetricsRecordAction(UserMetricsAction(metric.c_str()), NULL);
std::string checked_str = WideToUTF8(ExtractStringValue(args));
+ std::string metric =
+ (checked_str == "true" ? "Options_SSL2_Enable"
+ : "Options_SSL2_Disable");
net::SSLConfigServiceWin::SetSSL2Enabled(checked_str == "true");
}
« no previous file with comments | « chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc ('k') | chrome/browser/dom_ui/browser_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698