Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2036)

Unified Diff: chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc

Issue 3190004: dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Rebase to r56963. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc
===================================================================
--- chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc (revision 56963)
+++ chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc (working copy)
@@ -7,6 +7,7 @@
#include "base/json/json_reader.h"
#include "base/string_number_conversions.h"
#include "chrome/browser/chromeos/cros_settings.h"
+#include "chrome/browser/metrics/user_metrics.h"
#include "chrome/common/notification_service.h"
namespace chromeos {
@@ -30,9 +31,11 @@
void CoreChromeOSOptionsHandler::SetPref(const std::string& pref_name,
Value::ValueType pref_type,
- const std::string& value_string) {
+ const std::string& value_string,
+ const std::string& metric) {
if (!CrosSettings::IsCrosSettings(pref_name))
- return ::CoreOptionsHandler::SetPref(pref_name, pref_type, value_string);
+ return ::CoreOptionsHandler::SetPref(pref_name, pref_type, value_string,
+ metric);
CrosSettings* cros_settings = CrosSettings::Get();
switch (pref_type) {
@@ -57,6 +60,8 @@
break;
}
}
+
+ ProcessUserMetric(pref_type, value_string, metric);
}
void CoreChromeOSOptionsHandler::Observe(NotificationType type,
« no previous file with comments | « chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h ('k') | chrome/browser/dom_ui/advanced_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698