Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 3187019: Part 2 of the SSL InfoBubble. 2nd try, this time with test fixed.... (Closed)

Created:
10 years, 4 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Part 2 of the SSL InfoBubble. 2nd try, this time with test fixed. - Added Certificate Information link. - Changed iconography to be: Identity : Green check mark vs. Red skull and bones Connection: Green padlock vs. Orange exclamation point. (This used to be Green checkmark and Orange Exclamation point for both sections. - Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before. BUG=52916 TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57498

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -54 lines) Patch
M chrome/app/theme/pageinfo_bad.png View Binary file 0 comments Download
M chrome/app/theme/pageinfo_good.png View Binary file 0 comments Download
M chrome/browser/cocoa/page_info_window_mac_unittest.mm View 6 chunks +18 lines, -9 lines 0 comments Download
M chrome/browser/gtk/page_info_window_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/page_info_model.h View 3 chunks +18 lines, -6 lines 0 comments Download
M chrome/browser/page_info_model.cc View 5 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/views/page_info_bubble_view.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/views/page_info_bubble_view.cc View 10 chunks +66 lines, -29 lines 0 comments Download
M chrome/browser/views/page_info_window_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
OK, I couldn't test this change on the try bots yesterday since they barfed on ...
10 years, 4 months ago (2010-08-25 16:24:44 UTC) #1
Jay Civelli
10 years, 4 months ago (2010-08-25 16:31:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698