Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: chrome/browser/page_info_model.h

Issue 3187019: Part 2 of the SSL InfoBubble. 2nd try, this time with test fixed.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/page_info_window_gtk.cc ('k') | chrome/browser/page_info_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_info_model.h
===================================================================
--- chrome/browser/page_info_model.h (revision 57314)
+++ chrome/browser/page_info_model.h (working copy)
@@ -18,7 +18,7 @@
class Profile;
// The model that provides the information that should be displayed in the page
-// info dialog.
+// info dialog/bubble.
class PageInfoModel {
public:
class PageInfoModelObserver {
@@ -29,15 +29,23 @@
virtual ~PageInfoModelObserver() {}
};
+ enum SectionInfoType {
+ SECTION_INFO_IDENTITY = 0,
+ SECTION_INFO_CONNECTION,
+ SECTION_INFO_FIRST_VISIT,
+ };
+
struct SectionInfo {
SectionInfo(bool state,
const string16& title,
- const string16& head_line,
- const string16& description)
+ const string16& headline,
+ const string16& description,
+ SectionInfoType type)
: state(state),
title(title),
- head_line(head_line),
- description(description) {
+ headline(headline),
+ description(description),
+ type(type) {
}
bool state; // True if state is OK, false otherwise (ex of bad states:
@@ -47,10 +55,14 @@
string16 title;
// A single line describing the section, optional.
- string16 head_line;
+ string16 headline;
// The full description of what this section is.
string16 description;
+
+ // The type of SectionInfo we are dealing with, for example: Identity,
+ // Connection, First Visit.
+ SectionInfoType type;
};
PageInfoModel(Profile* profile,
« no previous file with comments | « chrome/browser/gtk/page_info_window_gtk.cc ('k') | chrome/browser/page_info_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698