Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Issue 3186020: Use a generic error instead of a dcheck. (Closed)

Created:
10 years, 4 months ago by chron_chromium.org
Modified:
9 years, 7 months ago
Reviewers:
Raghu Simha
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Use a generic error instead of a dcheck. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56904

Patch Set 1 #

Patch Set 2 : fix include name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/common/net/gaia/google_service_auth_error.h View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
chron_chromium.org
10 years, 4 months ago (2010-08-20 01:26:17 UTC) #1
Raghu Simha
10 years, 4 months ago (2010-08-20 01:43:00 UTC) #2
LGTM. I've verified that this fixes the test. Thanks for the prompt fix.

Powered by Google App Engine
This is Rietveld 408576698