Use a generic error instead of a dcheck.

chrome/common/net/gaia/google_service_auth_error.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A GoogleServiceAuthError is immutable, plain old data representing an
 // error from an attempt to authenticate with a Google service.
 // It could be from Google Accounts itself, or any service using Google
 // Accounts (e.g expired credentials).  It may contain additional data such as
 // captcha challenges.
 
 // A GoogleServiceAuthError without additional data is just a State, defined
 // below. A case could be made to have this relation implicit, to allow raising
 // error events concisely by doing OnAuthError(GoogleServiceAuthError::NONE),
 // for example. But the truth is this class is ever so slightly more than a
 // transparent wrapper around 'State' due to additional Captcha data
 // (e.g consider operator=), and this would violate the style guide. Thus,
 // you must explicitly use the constructor when all you have is a State.
 // The good news is the implementation nests the enum inside a class, so you
 // may forward declare and typedef GoogleServiceAuthError to something shorter
 // in the comfort of your own translation unit.
 
 #ifndef CHROME_COMMON_NET_GAIA_GOOGLE_SERVICE_AUTH_ERROR_H_
 #define CHROME_COMMON_NET_GAIA_GOOGLE_SERVICE_AUTH_ERROR_H_
 #pragma once
 
 #include <string>
 #include "base/logging.h"
 #include "googleurl/src/gurl.h"
+#include "net/base/net_errors.h"
 
 class GoogleServiceAuthError {
  public:
   enum State {
     // The user is authenticated.
     NONE = 0,
 
     // The password is valid but we need two factor to get a token.
     TWO_FACTOR,
 
@@ skipping 37 matching lines @@
             captcha_.token == b.captcha_.token &&
             captcha_.image_url == b.captcha_.image_url &&
             captcha_.unlock_url == b.captcha_.unlock_url);
   }
 
   // Construct a GoogleServiceAuthError from a State with no additional data.
   explicit GoogleServiceAuthError(State s)
       : state_(s),
         captcha_("", GURL(), GURL()),
         network_error_(0) {
-    DCHECK(s != CONNECTION_FAILED);
+    // If the caller has no idea, then we just set it to a generic failure.
+    if (s == CONNECTION_FAILED) {
+      network_error_ = net::ERR_FAILED;
+    }
   }
 
   // Construct a GoogleServiceAuthError from a network error.
   // It will be created with CONNECTION_FAILED set.
   static GoogleServiceAuthError FromConnectionError(int error) {
     return GoogleServiceAuthError(CONNECTION_FAILED, error);
   }
 
   // Construct a CAPTCHA_REQUIRED error with CAPTCHA challenge data.
   static GoogleServiceAuthError FromCaptchaChallenge(
@@ skipping 33 matching lines @@
         captcha_(captcha_token, captcha_image_url, captcha_unlock_url),
         network_error_(0) {
   }
 
   State state_;
   Captcha captcha_;
   int network_error_;
 };
 
 #endif  // CHROME_COMMON_NET_GAIA_GOOGLE_SERVICE_AUTH_ERROR_H_