Issue 3184024: Handle the case when there is unicode in the tree status more gracefully....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3184024: Handle the case when there is unicode in the tree status more gracefully.... (Closed)

Created:
10 years, 3 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Handle the case when there is unicode in the tree status more gracefully. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57447

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	presubmit_support.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

10 years, 3 months ago (2010-08-26 01:32:04 UTC) #2

http://codereview.chromium.org/3184024/diff/1/2
File presubmit_support.py (right):

http://codereview.chromium.org/3184024/diff/1/2#newcode117
presubmit_support.py:117:
output_stream.write('\n***************\n%s\n***************\n' %
why not u'' instead? This way the output would still be nice, at least on
non-windows OS.

Expand Messages | Collapse Messages