presubmit_support.py - Issue 3184024: Handle the case when there is unicode in the tree status more gracefully....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 3184024: Handle the case when there is unicode in the tree status more gracefully.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_support.py

===================================================================

--- presubmit_support.py (revision 57418)

+++ presubmit_support.py (working copy)

@@ -115,7 +115,7 @@

output_stream.write(' ' + ' \\\n '.join(map(str, self._items)) + '\n')

if self._long_text:

output_stream.write('\n***************\n%s\n***************\n' %

M-A Ruel 2010/08/26 01:32:05 why not u'' instead? This way the output would sti

- self._long_text)

+ self._long_text.encode('ascii', 'replace'))

if self.ShouldPrompt() and may_prompt:

if not PromptYesNo(input_stream, output_stream,

« no previous file with comments | « no previous file | no next file » | no next file with comments »