Fix "missing plugin" error in linux chrome....

Fix "missing plugin" error in linux chrome.
On linux first check succeeded, while next one will fail and no plugin information got returned.
So, I am inverting logic a little bit. IFF check for plugin file succeeded, we omit all
subsequent for this file in the process.

BUG=none
TEST=Check PDF plugin is working in Chrome linux sandbox, and no PDF plugin is in Chromium build.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55784

[gene, 2010-08-11 19:21:40]

Issue came back :), it is failing in Chrome now.
So, I inverted evan's logic a bit, to omit future checks and return PDF info,
IFF we already verified file existence.

[Evan Martin, 2010-08-11 19:25:13]

LGTM, thank you for fixing it!

[viettrungluu, 2010-08-11 19:34:34]

http://codereview.chromium.org/3181003/diff/1/2
File chrome/common/pepper_plugin_registry.cc (right):

http://codereview.chromium.org/3181003/diff/1/2#newcode112
chrome/common/pepper_plugin_registry.cc:112: if (skip_pdf_file_check ||
file_util::PathExists(path)) {
This isn't good for Chromium, since it'll result in spew (when it tries to do
the check from within the sandbox).

The problem is that we're trying to push a 3-state thing
(unknown/known-no-pdf/known-has-pdf) into a boolean....

[viettrungluu, 2010-08-11 19:35:30]

(Actually, I'm not sure if it results in spew; maybe the check just fails.
That'd be slightly suboptimal, but okay-ish, I guess.)

[Evan Martin, 2010-08-11 19:39:51]

http://codereview.chromium.org/3181003/diff/1/2
File chrome/common/pepper_plugin_registry.cc (right):

http://codereview.chromium.org/3181003/diff/1/2#newcode112
chrome/common/pepper_plugin_registry.cc:112: if (skip_pdf_file_check ||
file_util::PathExists(path)) {
On 2010/08/11 19:34:34, viettrungluu wrote:
> This isn't good for Chromium, since it'll result in spew (when it tries to do
> the check from within the sandbox).
> 
> The problem is that we're trying to push a 3-state thing
> (unknown/known-no-pdf/known-has-pdf) into a boolean....

PathExists doesn't spew.

[viettrungluu, 2010-08-11 19:46:26]

On 2010/08/11 19:39:51, Evan Martin wrote:
> http://codereview.chromium.org/3181003/diff/1/2
> File chrome/common/pepper_plugin_registry.cc (right):
> 
> http://codereview.chromium.org/3181003/diff/1/2#newcode112
> chrome/common/pepper_plugin_registry.cc:112: if (skip_pdf_file_check ||
> file_util::PathExists(path)) {
> On 2010/08/11 19:34:34, viettrungluu wrote:
> > This isn't good for Chromium, since it'll result in spew (when it tries to
do
> > the check from within the sandbox).
> > 
> > The problem is that we're trying to push a 3-state thing
> > (unknown/known-no-pdf/known-has-pdf) into a boolean....
> 
> PathExists doesn't spew.

Right. (Of course not, being a query....) LGTM.