Fix "missing plugin" error in linux chrome....

chrome/common/pepper_plugin_registry.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pepper_plugin_registry.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/native_library.h"
 #include "base/path_service.h"
@@ skipping 87 matching lines @@
   }
 }
 
 // static
 void PepperPluginRegistry::GetExtraPlugins(
     std::vector<PepperPluginInfo>* plugins) {
   // Once we're sandboxed, we can't know if the PDF plugin is
   // available or not; but (on Linux) this function is always called
   // once before we're sandboxed.  So the first time through test if
   // the file is available and then skip the check on subsequent calls
-  // if not.
-  static bool skip_pdf_plugin = false;
+  // if yes.
+  static bool skip_pdf_file_check = false;
   FilePath path;
-  if (!skip_pdf_plugin && PathService::Get(chrome::FILE_PDF_PLUGIN, &path)) {
-    if (!file_util::PathExists(path)) {
-      skip_pdf_plugin = true;
-      return;
+  if (PathService::Get(chrome::FILE_PDF_PLUGIN, &path)) {
+    if (skip_pdf_file_check || file_util::PathExists(path)) {

[viettrungluu, 2010/08/11 19:34:34]

This isn't good for Chromium, since it'll result in spew (when it tries to do
the check from within the sandbox).

The problem is that we're trying to push a 3-state thing
(unknown/known-no-pdf/known-has-pdf) into a boolean....

[Evan Martin, 2010/08/11 19:39:51]

PathExists doesn't spew.

+      PepperPluginInfo pdf;
+      pdf.path = path;
+      pdf.name = "Chrome PDF Viewer";
+      pdf.mime_types.push_back("application/pdf");
+      pdf.file_extensions = "pdf";
+      pdf.type_descriptions = "Portable Document Format";
+      plugins->push_back(pdf);
+
+      skip_pdf_file_check = true;
     }
-
-    PepperPluginInfo pdf;
-    pdf.path = path;
-    pdf.name = "Chrome PDF Viewer";
-    pdf.mime_types.push_back("application/pdf");
-    pdf.file_extensions = "pdf";
-    pdf.type_descriptions = "Portable Document Format";
-    plugins->push_back(pdf);
   }
 }
 
 PepperPluginRegistry::InternalPluginInfo::InternalPluginInfo() {
   is_internal = true;
 }
 
 // static
 void PepperPluginRegistry::GetInternalPluginInfo(
     InternalPluginInfoList* plugin_info) {
@@ skipping 60 matching lines @@
   for (size_t i = 0; i < plugins.size(); ++i) {
     const FilePath& path = plugins[i].path;
     ModuleHandle module = pepper::PluginModule::CreateModule(path);
     if (!module) {
       DLOG(ERROR) << "Failed to load pepper module: " << path.value();
       continue;
     }
     modules_[path] = module;
   }
 }