Fix bashisms: add quotes around paths

Fix bashisms: add quotes around paths

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57171

[Alexander Potapenko, 2010-08-24 11:41:57]

LGTM

On Tue, Aug 24, 2010 at 3:40 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Fix bashisms: add quotes around paths
>
> Please review this at http://codereview.chromium.org/3177031/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
>
> Affected files:
>  M     scripts/build-memcheck-for-chromium.sh
>  M     scripts/build-tsan-for-chromium.sh
>  M     scripts/common.sh
>
>
> Index: scripts/build-memcheck-for-chromium.sh
> ===================================================================
> --- scripts/build-memcheck-for-chromium.sh      (revision 56518)
> +++ scripts/build-memcheck-for-chromium.sh      (working copy)
> @@ -22,7 +22,7 @@
>  checkout_and_patch_valgrind "$MEMCHECK_SVN_REV" "$MEMCHECK_VEX_SVN_REV" \
>                             "$VG_MEMCHECK_DIR"
>
> -cd $VG_MEMCHECK_DIR
> +cd "$VG_MEMCHECK_DIR"
>
>  # Apply some Memcheck-specific pathes
>
> Index: scripts/build-tsan-for-chromium.sh
> ===================================================================
> --- scripts/build-tsan-for-chromium.sh  (revision 56521)
> +++ scripts/build-tsan-for-chromium.sh  (working copy)
> @@ -38,17 +38,17 @@
>            VALGRIND_ROOT="$VG_TSAN_DIR" $SPECIAL_TARGET
>
>   OUT_BIN="$ORIG_BINARIES_DIR/$PLATFORM/bin"
> -  mkdir -p $OUT_BIN
> +  mkdir -p "$OUT_BIN"
>   # See below for the definition of ORIG_BINARIES_DIR
> -  $THISDIR/tsan/tsan/mk-self-contained-valgrind.sh \
> +  "$THISDIR/tsan/tsan/mk-self-contained-valgrind.sh" \
>     "$VG_TSAN_DIR/out/$PLATFORM" "tsan" \
>     "$OUT_BIN/valgrind-tsan.sh"
>  }
>
>  TSAN_REV=2386
>  TSAN_DIR="$THISDIR/tsan" # Directory to checkout TSan sources
> -rm -rf $TSAN_DIR
> -svn co -r "$TSAN_REV" http://data-race-test.googlecode.com/svn/trunk
> $TSAN_DIR
> +rm -rf "$TSAN_DIR"
> +svn co -r "$TSAN_REV" http://data-race-test.googlecode.com/svn/trunk
> "$TSAN_DIR"
>
>  VG_TSAN_DIR="$THISDIR/valgrind" # Directory to checkout Valgrind sources
>  sh tsan/third_party/update_valgrind.sh # Fetch sources from
> valgrind-variant
> @@ -81,6 +81,6 @@
>  # Ugly hack!
>  # We build Valrgind binaries in the $VG_TSAN_DIR/out and then pack
>  # them into self-contained .sh file into $ORIG_BINARIES_DIR/$PLATFORM
> -ORIG_BINARIES_DIR=$BINARIES_DIR
> +ORIG_BINARIES_DIR="$BINARIES_DIR"
>  BINARIES_DIR="$VG_TSAN_DIR/out"
>  build_valgrind_for_available_platforms
> Index: scripts/common.sh
> ===================================================================
> --- scripts/common.sh   (revision 56518)
> +++ scripts/common.sh   (working copy)
> @@ -20,7 +20,7 @@
>   # $3 = source dir
>   # Checkout Valgrind, apply our patches to Valgrind.
>   # The source will be put in $THISDIR/valgrind-source
> -  cd $THISDIR
> +  cd "$THISDIR"
>   VG_REV="$1"
>   VEX_REV="$2"
>   SOURCE_DIR="$3"
> @@ -152,7 +152,7 @@
>
>   # Delete un-needed stuff from the $OUTPUT_DIR
>   # TODO(timurrrr): probably, we should just don't build the unused tools
> -  cd $OUTPUT_DIR
> +  cd "$OUTPUT_DIR"
>   rm -rf include
>   rm -rf lib/pkgconfig lib/*.a
>   rm bin/*cg_* bin/callgrind*
> @@ -177,7 +177,7 @@
>   fi
>
>   # We're done
> -  cd $PREV_DIR
> +  cd "$PREV_DIR"
>   # }}}
>  }
>
> @@ -229,7 +229,7 @@
>
>  # Check that the binaries directory exists.
>  BINARIES_DIR="$THISDIR/../binaries"
> -if ! [ -a $BINARIES_DIR ]
> +if ! [ -a "$BINARIES_DIR" ]
>  then
>   echo "Error: $BINARIES_DIR doesn't exist!" >&2
>   exit 1
>
>
>