Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: scripts/build-tsan-for-chromium.sh

Issue 3177031: Fix bashisms: add quotes around paths (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/build-memcheck-for-chromium.sh ('k') | scripts/common.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/build-tsan-for-chromium.sh
===================================================================
--- scripts/build-tsan-for-chromium.sh (revision 56521)
+++ scripts/build-tsan-for-chromium.sh (working copy)
@@ -38,17 +38,17 @@
VALGRIND_ROOT="$VG_TSAN_DIR" $SPECIAL_TARGET
OUT_BIN="$ORIG_BINARIES_DIR/$PLATFORM/bin"
- mkdir -p $OUT_BIN
+ mkdir -p "$OUT_BIN"
# See below for the definition of ORIG_BINARIES_DIR
- $THISDIR/tsan/tsan/mk-self-contained-valgrind.sh \
+ "$THISDIR/tsan/tsan/mk-self-contained-valgrind.sh" \
"$VG_TSAN_DIR/out/$PLATFORM" "tsan" \
"$OUT_BIN/valgrind-tsan.sh"
}
TSAN_REV=2386
TSAN_DIR="$THISDIR/tsan" # Directory to checkout TSan sources
-rm -rf $TSAN_DIR
-svn co -r "$TSAN_REV" http://data-race-test.googlecode.com/svn/trunk $TSAN_DIR
+rm -rf "$TSAN_DIR"
+svn co -r "$TSAN_REV" http://data-race-test.googlecode.com/svn/trunk "$TSAN_DIR"
VG_TSAN_DIR="$THISDIR/valgrind" # Directory to checkout Valgrind sources
sh tsan/third_party/update_valgrind.sh # Fetch sources from valgrind-variant
@@ -81,6 +81,6 @@
# Ugly hack!
# We build Valrgind binaries in the $VG_TSAN_DIR/out and then pack
# them into self-contained .sh file into $ORIG_BINARIES_DIR/$PLATFORM
-ORIG_BINARIES_DIR=$BINARIES_DIR
+ORIG_BINARIES_DIR="$BINARIES_DIR"
BINARIES_DIR="$VG_TSAN_DIR/out"
build_valgrind_for_available_platforms
« no previous file with comments | « scripts/build-memcheck-for-chromium.sh ('k') | scripts/common.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698