Issue 3177023: Implement Password Exceptions Tab

Issue 3177023: Implement Password Exceptions Tab (Closed)

Created:
10 years, 4 months ago by sargrass

Modified:
9 years, 7 months ago

Reviewers:
csilv, zel

CC:
chromium-reviews, dhg, arv (Not doing code reviews), ben+cc_chromium.org, James Hawkins, Evan Stade

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Implement Password Exceptions Tab. Separate the password exceptions list. BUG=49093 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56931

Patch Set 3 : add what was removed #

Patch Set 4 : looking for local string problem #

Patch Set 6 : sync to old revision for trybot #

Patch Set 7 : update the list value parse method #

Patch Set 10 : implement base class #

Patch Set 11 : base class work #

Total comments: 2

Patch Set 13 : sync #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+538 lines, -74 lines)			Patch
M	chrome/browser/dom_ui/options_ui.cc	View	3 4 5 6 7 8	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/passwords_exceptions_handler.h	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+60 lines, -13 lines	0 comments	Download
M	chrome/browser/dom_ui/passwords_exceptions_handler.cc	View	1 2 3 4 5 6	8 chunks	+84 lines, -20 lines	0 comments	Download
A	chrome/browser/dom_ui/passwords_remove_all_handler.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A	chrome/browser/dom_ui/passwords_remove_all_handler.cc	View		1 chunk	+41 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options.html	View	1 2 3 4 5 6 7 8 9 10 11	5 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/passwords_exceptions.html	View	1 2	1 chunk	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/options/passwords_exceptions.js	View	1 2	1 chunk	+55 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/options/passwords_exceptions_list.js	View	1 2	11 chunks	+198 lines, -21 lines	0 comments	Download
A	chrome/browser/resources/options/passwords_remove_all_overlay.html	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/options/passwords_remove_all_overlay.js	View	1 2 3 4	1 chunk	+50 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	3 4 5 6 7 8 9 10 11 12	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

csilv

http://codereview.chromium.org/3177023/diff/17001/18003 File chrome/browser/dom_ui/passwords_exceptions_handler.h (right): http://codereview.chromium.org/3177023/diff/17001/18003#newcode74 chrome/browser/dom_ui/passwords_exceptions_handler.h:74: // A short class to mediate requests to the ...

10 years, 4 months ago (2010-08-20 20:04:20 UTC) #3

sargrass

10 years, 4 months ago (2010-08-20 21:23:45 UTC) #4

csilv

LGTM http://codereview.chromium.org/3177023/diff/23001/20004 File chrome/browser/dom_ui/passwords_exceptions_handler.h (right): http://codereview.chromium.org/3177023/diff/23001/20004#newcode94 chrome/browser/dom_ui/passwords_exceptions_handler.h:94: } Add a line break after this line ...

10 years, 4 months ago (2010-08-20 21:32:54 UTC) #5

sargrass

http://codereview.chromium.org/3177023/diff/23001/20004 File chrome/browser/dom_ui/passwords_exceptions_handler.h (right): http://codereview.chromium.org/3177023/diff/23001/20004#newcode94 chrome/browser/dom_ui/passwords_exceptions_handler.h:94: } On 2010/08/20 21:32:54, csilv wrote: > Add a ...

10 years, 4 months ago (2010-08-20 22:40:10 UTC) #6

Expand Messages | Collapse Messages