Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5197)

Unified Diff: chrome/browser/resources/options/passwords_exceptions.js

Issue 3177023: Implement Password Exceptions Tab (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: sync Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/passwords_exceptions.js
diff --git a/chrome/browser/resources/options/passwords_exceptions.js b/chrome/browser/resources/options/passwords_exceptions.js
index 3a979befa7e4dd5318ce94616fd4d4c79439b9f5..f325b1d00acb6ba4c0d36d59d93d13d849ec0b32 100644
--- a/chrome/browser/resources/options/passwords_exceptions.js
+++ b/chrome/browser/resources/options/passwords_exceptions.js
@@ -28,36 +28,79 @@ cr.define('options', function() {
initializePage: function() {
OptionsPage.prototype.initializePage.call(this);
- options.passwordsExceptions.ListArea.decorate($('passwordsArea'));
+ options.passwordsExceptions.PasswordsListArea.decorate($('passwordsArea'));
+ options.passwordsExceptions.PasswordExceptionsListArea.decorate(
+ $('passwordExceptionsArea'));
- // TODO(sargrass): Passwords filter page --------------------------
-
- // TODO(sargrass): Exceptions filter page -------------------------
+ $('password-exceptions-nav-tab').onclick = function() {
+ OptionsPage.showTab($('password-exceptions-nav-tab'));
+ passwordExceptionsList.redraw();
+ }
+ },
+ setSavedPasswordsList_: function(entries) {
+ savedPasswordsList.clear();
+ for (var i = 0; i < entries.length; i++) {
+ savedPasswordsList.addEntry(entries[i]);
+ }
},
- setAutofillableLogins_: function(entries) {
- autofillableLoginsList.clear();
+ setPasswordExceptionsList_: function(entries) {
+ passwordExceptionsList.clear();
for (var i = 0; i < entries.length; i++) {
- autofillableLoginsList.addEntry(entries[i]);
+ passwordExceptionsList.addEntry(entries[i]);
}
},
+
};
PasswordsExceptions.load = function() {
- chrome.send('loadSavedPasswords');
+ chrome.send('loadLists');
};
- PasswordsExceptions.removeAutofillable = function(index) {
- chrome.send('removeAutofillable', [String(index)]);
+ /**
+ * Call to remove a saved password.
+ * @param rowIndex indicating the row to remove.
+ */
+ PasswordsExceptions.removeSavedPassword = function(rowIndex) {
+ chrome.send('removeSavedPassword', [String(rowIndex)]);
+ };
+
+ /**
+ * Call to remove a password exception.
+ * @param rowIndex indicating the row to remove.
+ */
+ PasswordsExceptions.removePasswordException = function(rowIndex) {
+ chrome.send('removePasswordException', [String(rowIndex)]);
+ };
+
+
+ /**
+ * Call to remove all saved passwords.
+ * @param tab contentType of the tab currently on.
+ */
+ PasswordsExceptions.removeAllPasswords = function() {
+ chrome.send('removeAllSavedPasswords');
+ };
+
+ /**
+ * Call to remove all saved passwords.
+ * @param tab contentType of the tab currently on.
+ */
+ PasswordsExceptions.removeAllPasswordExceptions = function() {
+ chrome.send('removeAllPasswordExceptions');
};
PasswordsExceptions.showSelectedPassword = function(index) {
chrome.send('showSelectedPassword', [String(index)]);
};
- PasswordsExceptions.setAutofillableLogins = function(entries) {
- PasswordsExceptions.getInstance().setAutofillableLogins_(entries);
+ PasswordsExceptions.setSavedPasswordsList = function(entries) {
+ PasswordsExceptions.getInstance().setSavedPasswordsList_(entries);
+ };
+
+ PasswordsExceptions.setPasswordExceptionsList = function(entries) {
+ PasswordsExceptions.getInstance().setPasswordExceptionsList_(entries);
};
PasswordsExceptions.selectedPasswordCallback = function(password) {

Powered by Google App Engine
This is Rietveld 408576698