Issue 3177001: Merge 54804 - [Mac] Enable click-drag-release behavior in the Wrench menu's c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3177001: Merge 54804 - [Mac] Enable click-drag-release behavior in the Wrench menu's c... (Closed)

Created:
10 years, 4 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Description

Merge 54804 - [Mac] Enable click-drag-release behavior in the Wrench menu's custom items. XIB changes: * Replace the edit item's segmented control with 3 buttons * Make the root view of both items a MenuTrackedRootView * Use the custom MenuTrackedButton for all the buttons BUG=49356 TEST=Click open the Wrench menu, hold, and drag over the buttons and they perform their function. Review URL: http://codereview.chromium.org/3072014 TBR=rsesek@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55633

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1003 lines, -141 lines)			Patch
M	chrome/app/nibs/Toolbar.xib	View	33 chunks	+960 lines, -120 lines	0 comments	Download
A +	chrome/browser/cocoa/menu_tracked_button.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/cocoa/menu_tracked_button.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/cocoa/menu_tracked_button_unittest.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/cocoa/menu_tracked_root_view.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/cocoa/menu_tracked_root_view.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/cocoa/menu_tracked_root_view_unittest.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/cocoa/wrench_menu_controller.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/wrench_menu_controller.mm	View	5 chunks	+37 lines, -24 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages