Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 3072014: [Mac] Enable click-drag-release behavior in the Wrench menu's custom items. (Closed)

Created:
10 years, 4 months ago by Robert Sesek
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[Mac] Enable click-drag-release behavior in the Wrench menu's custom items. XIB changes: * Replace the edit item's segmented control with 3 buttons * Make the root view of both items a MenuTrackedRootView * Use the custom MenuTrackedButton for all the buttons BUG=49356 TEST=Click open the Wrench menu, hold, and drag over the buttons and they perform their function. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54804

Patch Set 1 #

Total comments: 3

Patch Set 2 : address comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1273 lines, -149 lines) Patch
M chrome/app/nibs/Toolbar.xib View 33 chunks +960 lines, -120 lines 0 comments Download
A chrome/browser/cocoa/menu_tracked_button.h View 1 chunk +28 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/menu_tracked_button.mm View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/menu_tracked_button_unittest.mm View 1 chunk +117 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/menu_tracked_root_view.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/menu_tracked_root_view.mm View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/menu_tracked_root_view_unittest.mm View 1 chunk +45 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/wrench_menu_controller.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/wrench_menu_controller.mm View 5 chunks +39 lines, -26 lines 1 comment Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Robert Sesek
1. This is a big CL -- what do we think about getting it onto ...
10 years, 4 months ago (2010-08-03 01:10:49 UTC) #1
pink (ping after 24hrs)
LGTM. As far as merging to the branch, the toolbar.xib changes might be tricky to ...
10 years, 4 months ago (2010-08-03 14:53:51 UTC) #2
Nico
10 years, 4 months ago (2010-08-03 18:21:10 UTC) #3
driveby

http://codereview.chromium.org/3072014/diff/6001/7009
File chrome/browser/cocoa/wrench_menu_controller.mm (right):

http://codereview.chromium.org/3072014/diff/6001/7009#newcode135
chrome/browser/cocoa/wrench_menu_controller.mm:135: for (size_t i = 0; i <
kAdjustViewCount; ++i) {
nit: why not

  NSButton* views[] = { editPaste_, editCopy_, editCut_ };
  for (size_t i = 0; i < arraysize(views); ++i) {

(or UNSAFE_ARRAYSIZE if arraysize complains about something, but it only
complains about stuff with locally defined types iirc)

Powered by Google App Engine
This is Rietveld 408576698